From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH 3/4] ARM: dts: Include exynos5420-pinctrl after the nodes were defined Date: Wed, 08 Jul 2015 17:25:05 +0900 Message-ID: <559CDE61.2040804@samsung.com> References: <1436333790-18219-1-git-send-email-javier@osg.samsung.com> <1436333790-18219-4-git-send-email-javier@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <1436333790-18219-4-git-send-email-javier@osg.samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Javier Martinez Canillas , Kukjin Kim Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-samsung-soc@vger.kernel.org On 08.07.2015 14:36, Javier Martinez Canillas wrote: > The dtc compiler combines all the defined nodes that have the same path > so a device node definition can be in one file and later be extended in > another one. > > That's the case of the Exynos5420 pinctrl device nodes that are defined > in the exynos5420.dtsi file and extended in exynos5420-pinctrl.dtsi. > > But since the exynos5420.dtsi file includes the exynos5420-pinctrl.dtsi > before the pinctrl device nodes are actually defined, the definition of > the pinctrl device nodes happens in exynos5420-pinctrl.dtsi and are > extended in exynos5420.dtsi. > > That is the opposite of the original intention so even when there is no > difference in practice, the exynos5420-pinctrl.dtsi include should be > moved at the end of the exynos5420.dtsi file after the pinctrl device > nodes have been already defined. > > This will also allow to later change the exynos5420-pinctrl.dtsi file > to use labels instead of full paths to extend the pinctrl nodes. Since > keeping the include at the top, would cause a dtc build error due the > pinctrl labels not being defined yet. > > Signed-off-by: Javier Martinez Canillas > --- > > arch/arm/boot/dts/exynos5420.dtsi | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof