From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH] serial: samsung: Remove redundant DEBUG_LL check Date: Tue, 14 Jul 2015 10:56:31 +0900 Message-ID: <55A46C4F.8050803@samsung.com> References: <1436786331-5188-1-git-send-email-javier@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout4.w1.samsung.com ([210.118.77.14]:57843 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752667AbbGNB4h (ORCPT ); Mon, 13 Jul 2015 21:56:37 -0400 In-reply-to: <1436786331-5188-1-git-send-email-javier@osg.samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Javier Martinez Canillas , Greg Kroah-Hartman Cc: linux-samsung-soc@vger.kernel.org, Jiri Slaby , Arnd Bergmann , linux-kernel@vger.kernel.org, Kukjin Kim , linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org On 13.07.2015 20:18, Javier Martinez Canillas wrote: > Commit 84f57d9e3685 ("tty: serial/samsung: fix modular build") fixed > build issues when the driver was built as a module. One of those was > that printascii is only accessible when the driver is built-in. > > But there is no need to check for defined(CONFIG_DEBUG_LL) since the > SERIAL_SAMSUNG_DEBUG Kconfig symbol already depends on DEBUG_LL. > > Signed-off-by: Javier Martinez Canillas > > --- > > drivers/tty/serial/samsung.c | 1 - > 1 file changed, 1 deletion(-) Although this redundancy is not harmful the patch seems fine, so: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof