From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Kukjin Kim <kgene@kernel.org>, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 01/12] ARM: SAMSUNG: local regs-srom header in mach-exynos
Date: Tue, 28 Jul 2015 09:40:50 +0900 [thread overview]
Message-ID: <55B6CF92.8050904@samsung.com> (raw)
In-Reply-To: <013a01d0c87c$854d4d00$8fe7e700$@kernel.org>
On 27.07.2015 23:57, Kukjin Kim wrote:
>
> This patch moves regs-srom header file into mach-exynos.
Hi,
Minor nits:
1. Could you trim it and remove unnecessary empty line before description?
2. Could you answer in commit message: Why? Why are you moving the headers?
>
> c: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Malformed "Cc:" tag.
Best regards,
Krzysztof
> Signed-off-by: Kukjin Kim <kgene@kernel.org>
> ---
> arch/arm/{plat-samsung/include/plat => mach-exynos}/regs-srom.h | 3 +--
> arch/arm/mach-exynos/suspend.c | 4 ++--
> 2 files changed, 3 insertions(+), 4 deletions(-)
> rename arch/arm/{plat-samsung/include/plat => mach-exynos}/regs-srom.h (96%)
>
> diff --git a/arch/arm/plat-samsung/include/plat/regs-srom.h b/arch/arm/mach-exynos/regs-srom.h
> similarity index 96%
> rename from arch/arm/plat-samsung/include/plat/regs-srom.h
> rename to arch/arm/mach-exynos/regs-srom.h
> index 9b6729c..5c4d442 100644
> --- a/arch/arm/plat-samsung/include/plat/regs-srom.h
> +++ b/arch/arm/mach-exynos/regs-srom.h
> @@ -1,5 +1,4 @@
> -/* linux/arch/arm/plat-samsung/include/plat/regs-srom.h
> - *
> +/*
> * Copyright (c) 2010 Samsung Electronics Co., Ltd.
> * http://www.samsung.com
> *
> diff --git a/arch/arm/mach-exynos/suspend.c b/arch/arm/mach-exynos/suspend.c
> index c506f8e..e00eb39 100644
> --- a/arch/arm/mach-exynos/suspend.c
> +++ b/arch/arm/mach-exynos/suspend.c
> @@ -32,11 +32,11 @@
> #include <asm/suspend.h>
>
> #include <plat/pm-common.h>
> -#include <plat/regs-srom.h>
>
> #include "common.h"
> -#include "regs-pmu.h"
> #include "exynos-pmu.h"
> +#include "regs-pmu.h"
> +#include "regs-srom.h"
>
> #define REG_TABLE_END (-1U)
>
>
next prev parent reply other threads:[~2015-07-28 0:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 14:57 [PATCH 01/12] ARM: SAMSUNG: local regs-srom header in mach-exynos Kukjin Kim
2015-07-28 0:40 ` Krzysztof Kozlowski [this message]
2015-07-29 0:48 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B6CF92.8050904@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox