Re: [PATCH 10/14] exynos/fimg2d: remove default case from g2d_get_blend_op()

From: Inki Dae <inki.dae@samsung.com>
To: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>,
	linux-samsung-soc@vger.kernel.org
Cc: gustavo.padovan@collabora.co.uk, emil.l.velikov@gmail.com,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 10/14] exynos/fimg2d: remove default case from g2d_get_blend_op()
Date: Mon, 31 Aug 2015 22:25:43 +0900	[thread overview]
Message-ID: <55E455D7.8060101@samsung.com> (raw)
In-Reply-To: <1440425649-9768-11-git-send-email-tjakobi@math.uni-bielefeld.de>

On 2015년 08월 24일 23:14, Tobias Jakobi wrote:
> We now validate the blending mode via g2d_validate_mode()
> prior to feeding it to g2d_get_blend_op().
> 
> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
> ---
>  exynos/exynos_fimg2d.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/exynos/exynos_fimg2d.c b/exynos/exynos_fimg2d.c
> index 4274a94..d708e91 100644
> --- a/exynos/exynos_fimg2d.c
> +++ b/exynos/exynos_fimg2d.c
> @@ -91,11 +91,6 @@ static unsigned int g2d_get_blend_op(enum e_g2d_op op)
>  		SET_BF(val, G2D_COEFF_MODE_SRC_ALPHA, 0, 0, 0,
>  				G2D_COEFF_MODE_SRC_ALPHA, 1, 0, 0);
>  		break;
> -	default:
> -		fprintf(stderr, "Not support operation(%d).\n", op);
> -		SET_BF(val, G2D_COEFF_MODE_ONE, 0, 0, 0, G2D_COEFF_MODE_ZERO,
> -				0, 0, 0);
> -		break;

With this, how about changing above switch and case statement to if
statement?

Thanks,
Inki Dae

>  	}
>  
>  	return val.val;
> 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel