Re: [PATCH 0/7] add atomic_check callback to exynos_crtc

[Krzysztof Kozlowski <k.kozlowski@samsung.com>]

On 28.10.2015 14:38, Krzysztof Kozlowski wrote:
> On 28.10.2015 14:30, Inki Dae wrote:
>>
>>
>> 2015년 10월 28일 10:37에 Krzysztof Kozlowski 이(가) 쓴 글:
>>> On 26.10.2015 21:03, Andrzej Hajda wrote:
>>>> Hi Inki,
>>>>
>>>> This patchset removes hacky mode validation in Mixer driver by adding
>>>> atomic_check callback to exynos_crtc and replacing direct function call
>>>> with DRM framework validation. As a result HDMI driver does not depend anymore
>>>> on MIXER driver and both drivers can be selected with different Kconfig options,
>>>> it is usefull especially for latests SoCs which do have HDMI IP but do not have
>>>> MIXER IP.
>>>> Additionally patchset performs small Kconfig refactoring.
>>>>
>>>> Krzysztof could you look at exynos_defconfig patch. Maybe it would be good
>>>> to merge it before next patch to allow full bi-sectability :)
>>>
>>> I would be happy to see similar for multi_v7. HDMI is already there.
>>>
>>> I also wonder why actually DRM_EXYNOS_HDMI has to depend on MIXER or DECON?
>>
>> DECON controller has two kinds of data paths in case of Exynos5433 or later.
>> One is Display path and other is TV path. So it'd be reasonable for DRM_EXYNOS_HDMI to depend on MIXER or DECON -
>> TV path of DECON controller transfers Display data to HDMI like MIXER IP of previous Exynos SoC did.
> 
> So this is not a build-time dependency but rather runtime? What will
> happen if HDMI is compiled and enabled (for example in DTB) but there
> will be no DECON nor MIXER compiled in?
> 

Okay, I received the explanation off-line. :)

The solution looks good to me, I'll give the respective tags for
individual patches (please submit also multi_v7).

Best regards,
Krzysztof