From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alim Akhtar Subject: Re: [PATCH v2 2/3] rtc: s5m: Add separate field for storing auto-cleared mask in register config Date: Wed, 30 Dec 2015 15:39:04 +0530 Message-ID: <5683AD40.2010609@samsung.com> References: <1451450847-928-1-git-send-email-k.kozlowski@samsung.com> <1451450847-928-2-git-send-email-k.kozlowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mailout3.samsung.com ([203.254.224.33]:42011 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754176AbbL3KIn (ORCPT ); Wed, 30 Dec 2015 05:08:43 -0500 In-reply-to: <1451450847-928-2-git-send-email-k.kozlowski@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Krzysztof Kozlowski , Sangbeom Kim , Alessandro Zummo , Alexandre Belloni , Lee Jones , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, rtc-linux@googlegroups.com Cc: Yadwinder Singh Brar Hi Krzysztof, On 12/30/2015 10:17 AM, Krzysztof Kozlowski wrote: > Some devices from S2M/S5M family use different register update masks for > different operations (alarm and register update). Now the driver uses > common register configuration and a lot of exceptions per device in code. > > Before eliminating the exceptions and using specific register > configuration for given device, make the auto-cleared mask a separate > field. This is merely a refactoring. > > Signed-off-by: Krzysztof Kozlowski > Tested for s2mps15 pmic on exynos7-espresso board. Works well. Fill free to add Reviewed-by: Alim Akhtar Tested-by: Alim Akhtar > --- > > Changes since v1: > 1. None. > --- > drivers/rtc/rtc-s5m.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c > index 85649861a6b0..559db8f72117 100644 > --- a/drivers/rtc/rtc-s5m.c > +++ b/drivers/rtc/rtc-s5m.c > @@ -56,6 +56,8 @@ struct s5m_rtc_reg_config { > * auto-cleared after successful update. > */ > unsigned int udr_update; > + /* Auto-cleared mask in UDR field for writing time and alarm */ > + unsigned int autoclear_udr_mask; > /* Mask for UDR field in 'udr_update' register */ > unsigned int udr_mask; > }; > @@ -68,6 +70,7 @@ static const struct s5m_rtc_reg_config s5m_rtc_regs = { > .alarm0 = S5M_ALARM0_SEC, > .alarm1 = S5M_ALARM1_SEC, > .udr_update = S5M_RTC_UDR_CON, > + .autoclear_udr_mask = S5M_RTC_UDR_MASK, > .udr_mask = S5M_RTC_UDR_MASK, > }; > > @@ -82,6 +85,7 @@ static const struct s5m_rtc_reg_config s2mps_rtc_regs = { > .alarm0 = S2MPS_ALARM0_SEC, > .alarm1 = S2MPS_ALARM1_SEC, > .udr_update = S2MPS_RTC_UDR_CON, > + .autoclear_udr_mask = S2MPS_RTC_WUDR_MASK, > .udr_mask = S2MPS_RTC_WUDR_MASK, > }; > > @@ -167,7 +171,7 @@ static inline int s5m8767_wait_for_udr_update(struct s5m_rtc_info *info) > > do { > ret = regmap_read(info->regmap, info->regs->udr_update, &data); > - } while (--retry && (data & info->regs->udr_mask) && !ret); > + } while (--retry && (data & info->regs->autoclear_udr_mask) && !ret); > > if (!retry) > dev_err(info->dev, "waiting for UDR update, reached max number of retries\n"); >