Linux Samsung SOC development
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Sriram V <vshrirama@gmail.com>
Cc: linux-samsung-soc@vger.kernel.org
Subject: Re: domain off
Date: Wed, 20 Jan 2016 19:12:16 +0900	[thread overview]
Message-ID: <569F5D80.4040103@samsung.com> (raw)
In-Reply-To: <CAH9_wRPnvosp4sq3fBHGhd7G=V69s7qQdg3mUF_d08aWS4H_ng@mail.gmail.com>

On 20.01.2016 18:52, Sriram V wrote:
> Hi Krzyszof,
> 
> 
> 
> On Mon, Jan 11, 2016 at 7:51 AM, Krzysztof Kozlowski
> <k.kozlowski@samsung.com> wrote:
>> On 11.01.2016 10:48, Sriram V wrote:
>>> Hi Krzystof,
>>>
>>>
>>>
>>> On Mon, Jan 11, 2016 at 4:57 AM, Krzysztof Kozlowski
>>> <k.kozlowski@samsung.com> wrote:
>>>> 2016-01-10 22:49 GMT+09:00 Sriram V <vshrirama@gmail.com>:
>>>>> Hi Krzysztof,
>>>>>
>>>>> I see that in pm_genpd_sumarry, the domains are off. However, i still
>>>>> see the clocks are on.
>>>>> For example; isp and cam is turned off in pm_genpd_summary, however
>>>>> cam clocks are still on.
>>>>>
>>>>> Should'nt the clocks be turned off first and then the domain.
>>>>
>>>> No, the clocks in clock hierarchy are usually not disabled as a part
>>>> of domain power off. However respective drivers attached to a power
>>>> domain, when entering runtime suspend, should disable these clocks.
>>>>
>>>
>>> That is true, runtime suspend framework should disable the clocks.
>>> Hence, my question is if the clocks are active, Will disabling the
>>> domain take effect? Because when i print the status - they show that
>>> the domain is OFF.
>>
>> Yes, the domain will be disabled.
>>
>>>
>>> On my system, what i see is camera clocks are active, But the domain
>>> is OFF. Hence, i am not sure if camera subsystem is consuming power or
>>> not since clocks are on.
>>>
>>> >From my understanding, the domain status should not indicate OFF if
>>> any clocks are still on.
>>
>> Clocks and power domains in Linux are (mostly) independent subsystems so
>> the domain will be disabled even though some clocks are active. Some
>> clocks may be even missing in Linux (not defined) - it doesn't matter...
>>
>> It doesn't matter except in all the cases when this is a bug. :) The
>> clocks should be disabled and some muxes reparented to oscclk. One of
>> the cases we had was hang on reading clk_summary when power domain is off.
>>
> 
> Thanks for your pointers.
> 
> When i boot the kernel, I see that the following domains are currently
> on. I see that the following domains are currently on, Linux does not
> know about these domains and they are permanently on.
> 
> pd-fsys, pd-psgen, pd-peric, pd-wcore
> 
> Is there a way of finding out if these can be shut off. i dont think
> if clocks for the IP's serviced by these domains and the domain itself
> is correctly tied-in in runtime-pm. As these domains are always on.

The datasheet/reference manual in the "Local power control" describes
conditions whether they could be disabled or not. It also documents what
is required to power off them.

> 
> Also, what kernel are you using?

Usually mainline and linux-next.

In some of the projects I use different ones, e.g. these on tizen.org
(https://review.tizen.org/git/?p=platform/kernel/linux-exynos.git;a=summary).

Best regards,
Krzysztof

  reply	other threads:[~2016-01-20 10:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-09 10:19 domain off Sriram V
2016-01-10  6:15 ` Krzysztof Kozlowski
2016-01-10 13:49   ` Sriram V
2016-01-10 23:27     ` Krzysztof Kozlowski
2016-01-11  1:48       ` Sriram V
2016-01-11  2:21         ` Krzysztof Kozlowski
2016-01-20  9:52           ` Sriram V
2016-01-20 10:12             ` Krzysztof Kozlowski [this message]
2016-01-20 10:35               ` Sriram V
2016-01-20 13:30                 ` Krzysztof Kozłowski
2016-01-25  9:54                   ` Sriram V
2016-01-25 11:40                     ` Krzysztof Kozłowski
2016-02-04 12:21                       ` Sriram V
2016-02-05  1:13                         ` Krzysztof Kozłowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=569F5D80.4040103@samsung.com \
    --to=k.kozlowski@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=vshrirama@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox