From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Markus Reichl <m.reichl@fivetechno.de>,
Kukjin Kim <kgene@kernel.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: exynos-5422-odroid: Add eMMC and SD regulator supplies
Date: Mon, 04 Apr 2016 09:28:43 +0900 [thread overview]
Message-ID: <5701B53B.8000703@samsung.com> (raw)
In-Reply-To: <56FE7AC4.4090508@fivetechno.de>
On 01.04.2016 22:42, Markus Reichl wrote:
> Add vmmc and vqmmc supplies from MF circuit sheets for eMMC and SD on
> odroid XU3 and XU4 to avoid warnings in dmesg output.
What warnings?
>
> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
> ---
> arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> index 1bd507b..eec425a 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> @@ -121,7 +121,7 @@
> };
>
> ldo3_reg: LDO3 {
> - regulator-name = "vdd_ldo3";
> + regulator-name = "vddq_mmc0";
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
> regulator-always-on;
> @@ -184,7 +184,7 @@
> };
>
> ldo13_reg: LDO13 {
> - regulator-name = "vdd_ldo13";
> + regulator-name = "vddq_mmc2";
> regulator-min-microvolt = <2800000>;
> regulator-max-microvolt = <2800000>;
> regulator-always-on;
> @@ -211,6 +211,13 @@
> regulator-always-on;
> };
>
> + ldo18_reg: LDO18 {
> + regulator-name = "vdd_emmc_1V8";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
In the same patchset you add always-on and remove. What is the point of
this juggle?
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-04-04 0:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 13:42 [PATCH] ARM: dts: exynos-5422-odroid: Add eMMC and SD regulator supplies Markus Reichl
2016-04-04 0:28 ` Krzysztof Kozlowski [this message]
2016-04-04 8:35 ` Markus Reichl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5701B53B.8000703@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.reichl@fivetechno.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox