Linux Samsung SOC development
 help / color / mirror / Atom feed
From: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
To: dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org
Subject: drm/exynos: fimd: vrefresh is zero
Date: Sat, 30 Apr 2016 23:37:32 +0200	[thread overview]
Message-ID: <5725259C.9020206@math.uni-bielefeld.de> (raw)

Hello,

while playing around with FIMD enabled, I noticed that when first using
the device a zero division was triggered in fimd_calc_clkdiv(). I
remembered that I had a similar issue some time ago.

I added a stub fimd_atomic_check() which shows that vrefresh is zero
when fimd_calc_clkdiv() is called.

[  164.059361] [drm:exynos_plane_mode_set] plane : offset_x/y(0,0),
width/height(1366,768)
[  164.067175] [drm:fimd_atomic_check] xres=1366, yres=768, refresh=0,
intl=0
[  164.074198] [drm:drm_atomic_helper_check_planes] [CRTC:24:crtc-0]
atomic driver check failed

I went back to the git log and noticed that some time ago in
50bbfbffa5c894def440ce8157dfe53e60960d35 the fimd_mode_fixup() call was
removed.

I'm now wondering where exactly vrefresh is set to a sane value. As far
as I can see of_get_videomode() is used to fetch the video mode from the
DT, and drm_display_mode_from_videomode() is used to convert it. However
vrefresh is nowhere set.

So is something broken here, or am I missing something?

With best wishes,
Tobias

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

             reply	other threads:[~2016-04-30 21:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-30 21:37 Tobias Jakobi [this message]
2016-05-02 14:22 ` drm/exynos: fimd: vrefresh is zero Alex Deucher
2016-05-02 14:30   ` Tobias Jakobi
2016-05-02 20:22     ` Daniel Vetter
2016-05-02 20:30       ` Tobias Jakobi
2016-05-02 21:00         ` Daniel Vetter
2016-05-05  9:12           ` Andrzej Hajda
2016-05-05  9:22             ` Andrzej Hajda
2016-05-05 16:23               ` Tobias Jakobi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5725259C.9020206@math.uni-bielefeld.de \
    --to=tjakobi@math.uni-bielefeld.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox