From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH 2/4] bindings: spi-samsung: add exynos5433 spi compatible Date: Fri, 08 Jul 2016 14:51:23 +0200 Message-ID: <577FA1CB.30805@samsung.com> References: <1467980304-14093-1-git-send-email-andi.shyti@samsung.com> <1467980304-14093-3-git-send-email-andi.shyti@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <1467980304-14093-3-git-send-email-andi.shyti-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andi Shyti , Mark Brown Cc: Sylwester Nawrocki , Kukjin Kim , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andi Shyti List-Id: linux-samsung-soc@vger.kernel.org On 07/08/2016 02:18 PM, Andi Shyti wrote: > The samsung,exynos5433-spi has some peculiarities that bring the > need of creating a new compatible in the binding. That is not accurate. This for both: exynos5433 and exynos7. > > One of those is the 3-clocks controller management where the spi > is fed with three clocks: "spi", "busclkN" and "ioclk". > > Signed-off-by: Andi Shyti > --- > Documentation/devicetree/bindings/spi/spi-samsung.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/spi/spi-samsung.txt b/Documentation/devicetree/bindings/spi/spi-samsung.txt > index 6dbdeb3..d4294c7 100644 > --- a/Documentation/devicetree/bindings/spi/spi-samsung.txt > +++ b/Documentation/devicetree/bindings/spi/spi-samsung.txt > @@ -10,6 +10,7 @@ Required SoC Specific Properties: > - samsung,s3c6410-spi: for s3c6410 platforms > - samsung,s5pv210-spi: for s5pv210 and s5pc110 platforms > - samsung,exynos7-spi: for exynos7 platforms > + - samsung,exynos5433-spi: for exynos5433 compatible controllers As I wrote offline, proper order (alpha-numerical), so 5 before 7. > > - reg: physical base address of the controller and length of memory mapped > region. > Thanks for the patch, nice work. I see that you ignored parts of my offline comments so I guess you leave that work to others (describe required clock properties, deprecate exynos7-spi). I'll send the follow up then. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html