From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH 1/3] Revert "drivers/rtc/rtc-s3c.c: add .needs_src_clk to s3c6410 RTC data" Date: Mon, 11 Jul 2016 07:48:29 +0200 Message-ID: <5783332D.7010809@samsung.com> References: <1468056226-19128-1-git-send-email-ayaka@soulik.info> <1468056226-19128-2-git-send-email-ayaka@soulik.info> Reply-To: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Sender: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-reply-to: <1468056226-19128-2-git-send-email-ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Randy Li Cc: alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org, rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-samsung-soc@vger.kernel.org On 07/09/2016 11:23 AM, Randy Li wrote: > This reverts commit 8792f7772f4f40ffc68bad5f28311205584b734d. > The s3c6410 rtc don't use rtc_src property, that property is designed > for Exynos5250 and Exynos5440. The problem reported in the commit > I mentioned should be fixed in the other way. ... so you break in this commit all the newer platforms because the rtc_src clock won't be enabled. Does not look right. Best regards, Krzysztof > > Signed-off-by: Randy Li > --- > drivers/rtc/rtc-s3c.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c > index d01ad7e..5dc18ca 100644 > --- a/drivers/rtc/rtc-s3c.c > +++ b/drivers/rtc/rtc-s3c.c > @@ -801,7 +801,6 @@ static struct s3c_rtc_data const s3c2443_rtc_data = { > > static struct s3c_rtc_data const s3c6410_rtc_data = { > .max_user_freq = 32768, > - .needs_src_clk = true, > .irq_handler = s3c6410_rtc_irq, > .set_freq = s3c6410_rtc_setfreq, > .enable_tick = s3c6410_rtc_enable_tick, > -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.