From: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
To: Inki Dae <inki.dae@samsung.com>, dri-devel@lists.freedesktop.org
Cc: airlied@linux.ie, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH] drm/exynos: remove unnecessary codes
Date: Mon, 16 Jan 2017 12:24:09 +0100 [thread overview]
Message-ID: <587CAD59.9000101@math.uni-bielefeld.de> (raw)
In-Reply-To: <1484558003-18691-2-git-send-email-inki.dae@samsung.com>
Seen this quite often lately. It should be be 'code' and not 'codes'.
Code in the programming context is always a collection of instructions.
With best wishes,
Tobias
Inki Dae wrote:
> This patch removes exynos_drm_crtc_cancel_page_flip call
> when drm is closed because at that time, events will be released
> by drm_events_release function.
>
> Change-Id: I156ea27a4c90aa87a27a50415515fa334148c912
> Signed-off-by: Inki Dae <inki.dae@samsung.com>
> ---
> drivers/gpu/drm/exynos/exynos_drm_drv.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c
> index 9d0df00..035d02e 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
> @@ -198,13 +198,7 @@ static int exynos_drm_open(struct drm_device *dev, struct drm_file *file)
> static void exynos_drm_preclose(struct drm_device *dev,
> struct drm_file *file)
> {
> - struct drm_crtc *crtc;
> -
> exynos_drm_subdrv_close(dev, file);
> -
> - list_for_each_entry(crtc, &dev->mode_config.crtc_list, head)
> - exynos_drm_crtc_cancel_page_flip(crtc, file);
> -
> }
>
> static void exynos_drm_postclose(struct drm_device *dev, struct drm_file *file)
>
next prev parent reply other threads:[~2017-01-16 11:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170116091327epcas5p11cf9bbd8abe89543df059688abc32fb7@epcas5p1.samsung.com>
2017-01-16 9:13 ` [PATCH] drm/exynos: use atomic helper commit Inki Dae
2017-01-16 9:13 ` [PATCH] drm/exynos: remove unnecessary codes Inki Dae
2017-01-16 9:21 ` Inki Dae
2017-01-16 9:37 ` Andrzej Hajda
2017-01-17 6:03 ` Inki Dae
2017-01-16 11:24 ` Tobias Jakobi [this message]
2017-01-16 11:22 ` [PATCH] drm/exynos: use atomic helper commit Tobias Jakobi
2017-01-17 6:16 ` Inki Dae
2017-01-16 19:08 ` Gustavo Padovan
2017-01-17 8:20 ` Inki Dae
2017-01-16 20:34 ` Laurent Pinchart
2017-01-17 6:20 ` Inki Dae
2017-01-17 9:17 ` Laurent Pinchart
2017-01-18 2:17 ` Inki Dae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=587CAD59.9000101@math.uni-bielefeld.de \
--to=tjakobi@math.uni-bielefeld.de \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox