From: Inki Dae <inki.dae@samsung.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Tobias Jakobi <tjakobi@math.uni-bielefeld.de>,
linux-samsung-soc@vger.kernel.org,
Dan Carpenter <dan.carpenter@oracle.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/exynos: fix a timeout loop
Date: Tue, 24 Jan 2017 09:07:17 +0900 [thread overview]
Message-ID: <58869AB5.9080808@samsung.com> (raw)
In-Reply-To: <20170123094101.GL17136@nuc-i3427.alporthouse.com>
2017년 01월 23일 18:41에 Chris Wilson 이(가) 쓴 글:
> On Mon, Jan 23, 2017 at 06:32:16PM +0900, Inki Dae wrote:
>>
>>
>> 2017년 01월 21일 01:54에 Tobias Jakobi 이(가) 쓴 글:
>>> From: Dan Carpenter <dan.carpenter@oracle.com>
>>>
>>> We were trying to print an error message if we timed out here, but the
>>> loop actually ends with "tries" set to UINT_MAX and not zero. Fix this
>>> by changing from tries-- to --tries.
>>
>> Sorry but I already know this patch from long ago but I'm not clear yet.
>> How the variable, tries, could have UNIT_MAX?
>
> The value of tries after the final loop is -1u. The WARN fires on a
> succesful read on the final loop, instead of the complete failure.
Ah, right. thanks.
> -Chris
>
next prev parent reply other threads:[~2017-01-24 1:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170120165445epcas5p1a5fd54c6617006d8b4922d2c0269b17a@epcas5p1.samsung.com>
2017-01-20 16:54 ` [PATCH] drm/exynos: fix a timeout loop Tobias Jakobi
2017-01-23 9:32 ` Inki Dae
2017-01-23 9:41 ` Chris Wilson
2017-01-24 0:07 ` Inki Dae [this message]
2016-10-13 10:20 [patch] " Dan Carpenter
2016-10-13 11:05 ` Tobias Jakobi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58869AB5.9080808@samsung.com \
--to=inki.dae@samsung.com \
--cc=chris@chris-wilson.co.uk \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=tjakobi@math.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox