From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Roy Luo" <royluo@google.com>, "Vinod Koul" <vkoul@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Thinh Nguyen" <Thinh.Nguyen@synopsys.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Peter Griffin" <peter.griffin@linaro.org>,
"André Draszik" <andre.draszik@linaro.org>,
"Tudor Ambarus" <tudor.ambarus@linaro.org>
Cc: Joy Chakraborty <joychakr@google.com>,
Naveen Kumar <mnkumar@google.com>,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v1 1/4] usb: dwc3: Add Google SoC DWC3 glue driver
Date: Tue, 7 Oct 2025 09:46:08 +0900 [thread overview]
Message-ID: <5c2c298b-b0c3-4fa5-97aa-75b44084248b@kernel.org> (raw)
In-Reply-To: <20251006232125.1833979-2-royluo@google.com>
On 07/10/2025 08:21, Roy Luo wrote:
> This patch adds support for the DWC3 USB controller found on Google
Please read submitting patches, how this should be written.
> Tensor SoCs. The controller features dual-role functionality and
> hibernation.
> +
> +static const struct dev_pm_ops dwc3_google_dev_pm_ops = {
> + SET_SYSTEM_SLEEP_PM_OPS(dwc3_google_pm_suspend, dwc3_google_pm_resume)
> + SET_RUNTIME_PM_OPS(dwc3_google_runtime_suspend, dwc3_google_runtime_resume,
> + dwc3_google_runtime_idle)
> + .complete = dwc3_google_complete,
> + .prepare = dwc3_google_prepare,
> +};
> +
> +static const struct of_device_id dwc3_google_of_match[] = {
> + { .compatible = "google,snps-dwc3" },
You cannot use compatible before documenting it. Read submitting patches.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-07 0:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-06 23:21 [PATCH v1 0/4] Add Google Tensor SoC USB support Roy Luo
2025-10-06 23:21 ` [PATCH v1 1/4] usb: dwc3: Add Google SoC DWC3 glue driver Roy Luo
2025-10-07 0:46 ` Krzysztof Kozlowski [this message]
2025-10-07 18:08 ` Roy Luo
2025-10-11 3:39 ` kernel test robot
2025-10-06 23:21 ` [PATCH v1 2/4] dt-bindings: usb: dwc3: Add Google SoC DWC3 USB Roy Luo
2025-10-07 0:44 ` Krzysztof Kozlowski
2025-10-07 9:09 ` Peter Griffin
2025-10-07 14:18 ` Krzysztof Kozlowski
2025-10-07 18:49 ` Roy Luo
2025-10-06 23:21 ` [PATCH v1 3/4] usb: dwc3: Add Google SoC USB PHY driver Roy Luo
2025-10-07 0:42 ` Krzysztof Kozlowski
2025-10-07 5:51 ` Greg Kroah-Hartman
2025-10-07 18:57 ` Roy Luo
2025-10-06 23:21 ` [PATCH v1 4/4] dt-bindings: phy: google: Add Google SoC USB PHY Roy Luo
2025-10-07 0:45 ` Krzysztof Kozlowski
2025-10-07 19:04 ` Roy Luo
2025-10-07 1:06 ` [PATCH v1 0/4] Add Google Tensor SoC USB support Krzysztof Kozlowski
2025-10-07 18:03 ` Roy Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c2c298b-b0c3-4fa5-97aa-75b44084248b@kernel.org \
--to=krzk@kernel.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=andre.draszik@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=joychakr@google.com \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mnkumar@google.com \
--cc=p.zabel@pengutronix.de \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=royluo@google.com \
--cc=tudor.ambarus@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox