From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 2/4] PM / Domains: Don't allow an existing generic PM domain data Date: Wed, 29 Oct 2014 15:28:16 -0700 Message-ID: <7hegtq5x4v.fsf@deeprootsystems.com> References: <1414507090-516-1-git-send-email-ulf.hansson@linaro.org> <1414507090-516-3-git-send-email-ulf.hansson@linaro.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1414507090-516-3-git-send-email-ulf.hansson@linaro.org> (Ulf Hansson's message of "Tue, 28 Oct 2014 15:38:08 +0100") Sender: linux-pm-owner@vger.kernel.org To: Ulf Hansson Cc: "Rafael J. Wysocki" , Len Brown , Pavel Machek , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Geert Uytterhoeven , Alan Stern , Greg Kroah-Hartman , Tomasz Figa , Simon Horman , Magnus Damm , Ben Dooks , Kukjin Kim , Philipp Zabel , Mark Brown , Wolfram Sang , Russell King , Dmitry Torokhov , Jack Dai , Jinkun Hong , Aaron Lu , Sylwester Nawrocki List-Id: linux-samsung-soc@vger.kernel.org Ulf Hansson writes: > While adding devices to the generic PM domain we allocate data for the > struct generic_pm_domain_data. > > Don't allow existing generic_pm_domain_data in this case, since that > indicates the device is already being added from another context. Let's > instead return an error. > > Signed-off-by: Ulf Hansson Similar to PATCH 1/4, it would be good to summarize/remind why this feature was added in the first place, and why it's not longer needed. Kevin