From: Krzysztof Kozlowski <krzk@kernel.org>
To: Umer Uddin <umer.uddin@mentallysanemainliners.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
igor.belwon@mentallysanemainliners.org
Subject: Re: [PATCH v3 3/4] arm64: dts: exynos: Add initial support for Samsung Galaxy S20 5G (x1s)
Date: Mon, 2 Dec 2024 09:53:04 +0100 [thread overview]
Message-ID: <88f6ab28-1b3f-4144-91c8-0131ee008838@kernel.org> (raw)
In-Reply-To: <9f48459e-f381-446a-86bf-c8d1bb8858bc@gmail.com>
On 14/11/2024 10:09, Ivaylo Ivanov wrote:
>> +
>> +/ {
>> + #address-cells = <2>;
>> + #size-cells = <2>;
>> +
>> + model = "Samsung Galaxy S20 5G";
>> + compatible = "samsung,x1s", "samsung,exynos990";
>> +
>> + memory@80000000 {
>> + device_type = "memory";
>> + reg = <0x0 0x80000000 0x0 0x3ab00000>,
>> + /* Memory hole */
>> + <0x0 0xc1200000 0x0 0x1ee00000>,
>> + /* Memory hole */
>> + <0x0 0xe1900000 0x0 0x1e700000>,
>> + /* Memory hole */
>
> The space from 0x100000000 to 0x880000000 isn't a hole in the memory
> though, is it? 0x880000000 is in the 64 bit address space.
>
> Best regards, Ivo.
Umer,
I wanted to apply the series, but for two weeks you ignored this
feedback/comment, so I am dropping the patchset from my queue.
Be sure you respond to reviewers in timely manner (and if you give
yourself more than two weeks to respond it also means other have more
than two weeks...).
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-12-02 8:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 23:23 [PATCH v3 0/4] Add minimal Samsung Galaxy S20 Series board, SM-G981B and SM-G980F support Umer Uddin
2024-10-30 23:23 ` [PATCH v3 1/4] dt-bindings: arm: samsung: samsung-boards: Add bindings for SM-G981B and SM-G980F board Umer Uddin
2024-10-30 23:23 ` [PATCH v3 2/4] arm64: dts: exynos: Add initial support for Samsung Galaxy S20 Series boards (hubble) Umer Uddin
2024-10-30 23:23 ` [PATCH v3 3/4] arm64: dts: exynos: Add initial support for Samsung Galaxy S20 5G (x1s) Umer Uddin
2024-11-14 9:09 ` Ivaylo Ivanov
2024-12-02 8:53 ` Krzysztof Kozlowski [this message]
2024-12-02 16:00 ` Umer Uddin
2024-12-02 16:03 ` Krzysztof Kozlowski
2024-12-02 16:05 ` Umer Uddin
2024-10-30 23:23 ` [PATCH v3 4/4] arm64: dts: exynos: Add initial support for Samsung Galaxy S20 (x1slte) Umer Uddin
2024-11-02 17:42 ` [PATCH v3 0/4] Add minimal Samsung Galaxy S20 Series board, SM-G981B and SM-G980F support Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2024-12-02 16:21 [RESEND,v3 " Umer Uddin
2024-12-02 16:21 ` [PATCH v3 3/4] arm64: dts: exynos: Add initial support for Samsung Galaxy S20 5G (x1s) Umer Uddin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88f6ab28-1b3f-4144-91c8-0131ee008838@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=igor.belwon@mentallysanemainliners.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=umer.uddin@mentallysanemainliners.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox