From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1B47C433EF for ; Fri, 11 Mar 2022 10:44:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235792AbiCKKpp (ORCPT ); Fri, 11 Mar 2022 05:45:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233132AbiCKKpp (ORCPT ); Fri, 11 Mar 2022 05:45:45 -0500 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DBFA14EF65 for ; Fri, 11 Mar 2022 02:44:42 -0800 (PST) Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 4BC9E3F203 for ; Fri, 11 Mar 2022 10:44:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1646995481; bh=/5MWLhD4xGT9FKI+CGPQQ/jYudzkVpDtSDj/hy41Z8E=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=XqLLCnZVMFR5K8gQEJGujDyVglx7vZI9uFi1HgHGBXdyPuSyrlRy9CfilDD4z3v7S pmf5cRstEPRGokALMoT1H+iXxZW3OxGG8jBaOknYSVMg8CpuZp8VI2TdI0XkG6jFxN n32LXZX4wZztJWiasmgnWtT65XnWko3/kdBVozknZUVRL1pAf5cUrMvJuvS5jgvd6y 2yIkDKecbpcsZOsBTPKrM14cb16gsvP6TUcpKflkpmfg/WgqM8gQw3VJ/rGQvD68uY S8VUKq6eJ+RzMQjgeI5OM8pQqJoMyKia8xgj/J5kXCK45jJkEDhodut9k7SfGMDhuz CAvE74yKgH5ZA== Received: by mail-ej1-f70.google.com with SMTP id ey18-20020a1709070b9200b006da9614af58so4731621ejc.10 for ; Fri, 11 Mar 2022 02:44:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=/5MWLhD4xGT9FKI+CGPQQ/jYudzkVpDtSDj/hy41Z8E=; b=bwghxEIY4NGZMYq5i8GW9/w8PVoo8addvFGz9eycdlVpBTOP/zyZrrWDjXlRg6aapm Xy73hTlhub7rDgDkql/WgpwEvYpGagVN9BJXUzdMrzLFKdQp/TrZi2rvxXmjR4ZNUXeB DMoaXR/6anCUvISxG2qNsfc7EL22VsxA2wo81Hj6w8ReqxozGQ2QZZejVyYAl5i2JSpU 7W5PLadpoB8ol/i4nVUvVLCr9DZ3rES0/p5j5h414DroPpWz13zj9H9wms4xMJB8I8WH 2gNVFkERVRxYJLr/FcHFOPDOWPtBUOMa59SfF11KOa7QLlWBNasS3zEfPDLB3ykZIgVB JnIQ== X-Gm-Message-State: AOAM533l9xIcJZX5ZLJulhVegiJYgGjXTlNLwFiWGQOyllnZch0tkA5M xJYpL/o9oR5B1LiTrWaPfPbR9EPHCIsh0DlWBOOXR/0qhqICbQ/Sfg9hpFNqSrGmUV10V88IJyl WD/4EcjzZMisRSHe4nbA/kvGjYxzVrHC68MeyJp1iVdD2rbbD X-Received: by 2002:a50:9d47:0:b0:40f:9d3d:97b6 with SMTP id j7-20020a509d47000000b0040f9d3d97b6mr8183325edk.392.1646995480932; Fri, 11 Mar 2022 02:44:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJzdKKDMjkHKVhdTP9g7nHC6x7lNkdrI2VetCVe5vQfigm+rGX2Rr0lQn3LcUVjzh7JdHNWMOQ== X-Received: by 2002:a50:9d47:0:b0:40f:9d3d:97b6 with SMTP id j7-20020a509d47000000b0040f9d3d97b6mr8183311edk.392.1646995480769; Fri, 11 Mar 2022 02:44:40 -0800 (PST) Received: from [192.168.0.148] (xdsl-188-155-174-239.adslplus.ch. [188.155.174.239]) by smtp.gmail.com with ESMTPSA id 5-20020a508e45000000b003fe03798eafsm3354795edx.32.2022.03.11.02.44.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Mar 2022 02:44:40 -0800 (PST) Message-ID: <9cc6fe19-bd66-ad49-188d-e35a085de397@canonical.com> Date: Fri, 11 Mar 2022 11:44:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 2/2] tty: serial: samsung: Add ARTPEC-8 support Content-Language: en-US From: Krzysztof Kozlowski To: gregkh@linuxfoundation.org Cc: kernel@axis.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-serial@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, alim.akhtar@samsung.com, jirislaby@kernel.org, Vincent Whitchurch References: <20220311094515.3223023-1-vincent.whitchurch@axis.com> <20220311094515.3223023-3-vincent.whitchurch@axis.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On 11/03/2022 11:42, Krzysztof Kozlowski wrote: > On 11/03/2022 10:45, Vincent Whitchurch wrote: >> Add support for the UART block on the ARTPEC-8 SoC. This is closely >> related to the variants used on the Exynos chips. The register layout >> is identical to Exynos850 et al but the fifo size is different (64 bytes >> in each direction for all instances). >> >> Reviewed-by: Krzysztof Kozlowski >> Signed-off-by: Vincent Whitchurch >> --- >> >> Notes: >> v2: >> - Added Krzysztof's Reviewed-by. >> - Expanded commit message >> - Fixed fifo size >> - Rebased on top of Krzysztof's "minor fixes/cleanups" series. This needed a >> couple of fixes for build errors. >> >> (I'm always unsure if Reviewed-by should be carried over or not if the fixes >> are minor. I apologize in advance if carring it over was the wrong thing to do >> in this case.) > > For minor fixes, usually we carry Rb tag over. It's fine. > Hi Greg, Just one note for you - this depends now on my v3 patchset here: https://lore.kernel.org/all/20220308080919.152715-1-krzysztof.kozlowski@canonical.com/ Best regards, Krzysztof