From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C169823371B; Tue, 16 Dec 2025 16:36:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765902988; cv=none; b=mw66p4vvbbNf2fnnrssKlcUmGpfti0n0pP+ZuNJqMMzKfqffC6M8NnHyzY8JfBRMtwYagJ1i2EEElZkL+FQYqfmZGxSj2SXBauZIgs544moHSPE6buBA+q9LxbFwQfAZQwDljr+JyKV+uO60MKJZWJ4Bb2oV0puUAdNXvN82BrA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765902988; c=relaxed/simple; bh=oFjVZa6cQDUNg1q8/naTH9lAAeiTjOcFhVLNBZ1HADw=; h=Mime-Version:Content-Type:Date:Message-Id:From:Subject:Cc:To: References:In-Reply-To; b=qFbJ2dTfoE5yepWacRSi6zwRW6ogua6H0FMjbqAuOVe2sHafTwEewggt7nLTsI1g1e79pvkIBDSRZVHYqf6O7v3GgHVGDMQyc+LVCpQTl+HFZoiqrIAqQx0GDoR1PwqBURFGthqPQfuI2JRMec1z3u41bmwk/X7qUpTReueMjvI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=Hxcp1qe0; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="Hxcp1qe0" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id E962E1A223D; Tue, 16 Dec 2025 16:36:24 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id A76266071C; Tue, 16 Dec 2025 16:36:24 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id F316C119A904B; Tue, 16 Dec 2025 17:36:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1765902982; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=PzhR0G4mBnm/z0O1Hfgh44ISCPhT1HMJphLOZLV+TY0=; b=Hxcp1qe0jp9L+ZP5B2CcjRugnzvNJMFJ/9uLnc/dPwH5UC2kAbZKmRyiMLwCIMY3l1rGeB r1i0PJRzjjFJ9grjtuxiAKvLXLVgaYVMvrqPir01kIYE5+3GlMEUdCh/SeWGh8FfSmc4dD BQCAl/r7vtgA55arSrrcGj571k5Y7jabJyHmtN3hyRh7HvY9LH9G+IEVTIcBK5YF8EbLdi mePmspCgWnZbPbX9OJXUW7hcaIiZlm5vXCzrPfRFRz3YSxNhCgjgDAJf2WLsdzNMJz7Sdl go01yz6G44JOyfuUCxKxAYqzeeuqGpt1lByELY1A2jHL5QL1gBe/telVFa0/Cw== Precedence: bulk X-Mailing-List: linux-samsung-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 16 Dec 2025 17:36:07 +0100 Message-Id: From: "Luca Ceresoli" Subject: Re: [PATCH 06/26] drm/bridge: add devm_drm_of_find_bridge Cc: "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Maarten Lankhorst" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Jonathan Corbet" , "Alexey Brodkin" , "Phong LE" , "Liu Ying" , "Shawn Guo" , "Sascha Hauer" , "Pengutronix Kernel Team" , "Fabio Estevam" , "Adrien Grassein" , "Laurent Pinchart" , "Tomi Valkeinen" , "Kieran Bingham" , "Geert Uytterhoeven" , "Magnus Damm" , "Kevin Hilman" , "Jerome Brunet" , "Martin Blumenstingl" , "Chun-Kuang Hu" , "Philipp Zabel" , "Matthias Brugger" , "AngeloGioacchino Del Regno" , "Anitha Chrisanthus" , "Edmund Dea" , "Inki Dae" , "Seung-Woo Kim" , "Kyungmin Park" , "Krzysztof Kozlowski" , "Alim Akhtar" , "Hui Pu" , "Thomas Petazzoni" , , , , , , , , , To: "Maxime Ripard" X-Mailer: aerc 0.20.1 References: <20251119-drm-bridge-alloc-getput-drm_of_find_bridge-v1-0-0db98a7fe474@bootlin.com> <20251119-drm-bridge-alloc-getput-drm_of_find_bridge-v1-6-0db98a7fe474@bootlin.com> <20251201-thick-jasmine-oarfish-1eceb0@houat> <20251215-mottled-dexterous-marmot-c69ad3@penduick> <20251216-cute-bandicoot-of-authority-3c492a@penduick> In-Reply-To: <20251216-cute-bandicoot-of-authority-3c492a@penduick> X-Last-TLS-Session-Version: TLSv1.3 Hi Maxime, On Tue Dec 16, 2025 at 2:49 PM CET, Maxime Ripard wrote: [...] >> Not sure why, but it's taking a while before I grasp your ideas about th= is >> series and meld them with mine. I hopefully got a clear POV now, so base= d >> on it my plan is to rework this series to: >> >> * keep drm_of_find_bridge() but renamed to of_drm_get_bridge(), and kee= p >> patches 1-5 (with the changes suggested by you and Louis, nothing big >> and all already sent in v2) > > I don't think we should use that name, but on principle, yes. OK about the rename. I just had sent this email before you requested the rename. v3 is in the works with the of_drm_find_and_get_bridge() name. >> * not add devm_drm_of_find_bridge() > > Yep. > >> * add next_bridge pointer to struct drm_bridge and call >> drm_bridge_put(bridge->next_bridge) in __drm_bridge_free, document it > > We don't have to at this point, you can add next_bridge to the > drm_bridge pointer if you want, but I don't consider it a prerequisite. > If we don't we would have to create drm_bridge_funcs->destroy > implemnentations to give up the driver pointer reference though. Your > call. There's a destroy finc already, so I'm adding the next_bridge pointer in v3 along with some driver conversions, including one where the destroy hook is needed. >> * convert patches 7-26 to use bridge->next_bridge where applicable, >> or to do something different when needed > > Depending on your decision above, we'd need to either convert them to > use drm_bridge->next_bridge or create a destroy hook for them. Either > way is fine for me. > >> * maybe remove part of patches 7-26 just to reduce spam and rework effo= rt >> in case of further iterations, to send them separately once the appro= ach >> is accepted >> >> Does it look OK? Cool, thanks for acking. v3 is just a testing round away from being sent. Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com