From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05E96C433EF for ; Wed, 29 Jun 2022 10:13:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232673AbiF2KNU (ORCPT ); Wed, 29 Jun 2022 06:13:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231338AbiF2KNU (ORCPT ); Wed, 29 Jun 2022 06:13:20 -0400 X-Greylist: delayed 1654 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 29 Jun 2022 03:13:16 PDT Received: from 13.mo584.mail-out.ovh.net (13.mo584.mail-out.ovh.net [178.33.251.8]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 064FF21265 for ; Wed, 29 Jun 2022 03:13:15 -0700 (PDT) Received: from player731.ha.ovh.net (unknown [10.111.208.192]) by mo584.mail-out.ovh.net (Postfix) with ESMTP id A278C1FFB1 for ; Wed, 29 Jun 2022 09:33:43 +0000 (UTC) Received: from etezian.org (bbcs-175-223.cust.wingo.ch [178.238.175.223]) (Authenticated sender: andi@etezian.org) by player731.ha.ovh.net (Postfix) with ESMTPSA id 129A42BD37AE9; Wed, 29 Jun 2022 09:33:31 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-108S00272303c45-9778-4737-9c0f-c5461f48230c, 27473AD2557E96BAE247B01472F11916F8881100) smtp.auth=andi@etezian.org X-OVh-ClientIp: 178.238.175.223 Date: Wed, 29 Jun 2022 12:33:19 +0300 From: Andi Shyti To: Chanho Park Cc: Krzysztof Kozlowski , Andi Shyti , Mark Brown , Rob Herring , Krzysztof Kozlowski , Alim Akhtar , devicetree@vger.kernel.org, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/4] spi: s3c64xx: support loopback mode Message-ID: References: <20220628044222.152794-1-chanho61.park@samsung.com> <20220628044222.152794-2-chanho61.park@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220628044222.152794-2-chanho61.park@samsung.com> X-Ovh-Tracer-Id: 2051108159235492376 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrudegledgudeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvfevuffkfhggtggujgesthdtrodttddtvdenucfhrhhomheptehnughiucfuhhihthhiuceorghnughisegvthgviihirghnrdhorhhgqeenucggtffrrghtthgvrhhnpeefheefueelleeghfehgeeiudfgieefffdviedtjeduvdfhhfdthedvteeltdfhueenucfkpheptddrtddrtddrtddpudejkedrvdefkedrudejhedrvddvfeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhhvghlohepphhlrgihvghrjeefuddrhhgrrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegrnhguihesvghtvgiiihgrnhdrohhrghdpnhgspghrtghpthhtohepuddprhgtphhtthhopehlihhnuhigqdhsrghmshhunhhgqdhsohgtsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdfovfetjfhoshhtpehmohehkeeg Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Hi Chanho, On Tue, Jun 28, 2022 at 01:42:19PM +0900, Chanho Park wrote: > Modern exynos SoCs can support self loopback mode via setting BIT(3) of > MODE_CFG register. Previous SoCs don't have the bit so we need to add > has_loopback field in the s3c64xx_spi_port_config. Exynos Auto v9 SoC > has the bit and it will define the field to "true". > When it is set, SPI_LOOP mode will be marked. > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Chanho Park Reviewed-by: Andi Shyti Thanks, Andi