From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74E602D6E5B for ; Mon, 11 Aug 2025 15:57:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754927868; cv=none; b=hBlD0rZnW2CiaiIyc0BmXzpkfvArTFE/00m9bcX5RdNl6IQuLHz0ac+YZBhN/mrHA41ReZGtq8svUCgehLYx+d09pNZM5fWcXWKsQiXjkEmi3OMyD/FdSIj/sBtTU+FIy1JFcAg2Ds95yEMWSuJqIC/Eqy3V9U5vOwdo9ibFqfY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754927868; c=relaxed/simple; bh=07eO2bvYIRsiAjlhL5Ks2RMc74npsOWxeUj+fPHc9EM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YP/3X/JFMlM+SUhI/zSEB4PvXVKRNLSH2He2KrHkrvayX275pbPBoKU90y5DAbTccQ5LJVkdWQA41k7M84CsT+1IEAvlJ/V9PUUP4VTL8jXfei3o4Yj59K5RuamaBblkj2PJQeqTjBimsJApVRhoDnGeprGfxzIbduT7DmoLiOA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=iN2EhbD9; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iN2EhbD9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754927865; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UPMcKR4Oi745bR8iqUsDP5qg1uYaCMtbYLompUhICNQ=; b=iN2EhbD90ie9CgoZVivdz9sre9b3D2VhxMFSPXr82443LS5XVYsBZBJS3GaenR1zqD3r3r vNVf5vXrUJvYkljprd2yRlwZ+anMLZaWze/RNW989bOQiHjwcqdO0PgG2YWDAGGMfA6ngH Kn7kWXLB0lDk8wsaPK/R1E2LkxSfqks= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-531-ZyJ1k1MvO-Od4OwZJ7ZAXg-1; Mon, 11 Aug 2025 11:57:44 -0400 X-MC-Unique: ZyJ1k1MvO-Od4OwZJ7ZAXg-1 X-Mimecast-MFC-AGG-ID: ZyJ1k1MvO-Od4OwZJ7ZAXg_1754927862 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-70739ef4ab4so101056766d6.0 for ; Mon, 11 Aug 2025 08:57:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754927862; x=1755532662; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UPMcKR4Oi745bR8iqUsDP5qg1uYaCMtbYLompUhICNQ=; b=c6xEouJB7hANsuOK+0pfeKvEXPzKmzV/pmrTLXdjCwBRIXFijmLbVDQtRoSvcxRARC l/kIqEnQQIBYUTvcIrCIBqmkubWF1iTS3syioEOg4v8OECyksI6N/qcSoT1zM0D1SM7t gFsvRD6vtOtja/A4smSbopLJAsnLvytW9RePU20MOewWQq+N3lTOU6IpuyPWzfyQf3qH 21N4NaHfXtIaFzgR69eqgh/L5+SMHFQFZmuv7HOdIdBkIYF4ErHorJAC15IULwoKD5Hl jMhqi7JLs84970gy4a0g9nbXgcVXd4yZLXYj3++m/0EWvnShQesyUcXRQr4+uVg7zVft twEg== X-Forwarded-Encrypted: i=1; AJvYcCVeyjBP+/VIfSZ/VmPXMH5Rvdm5iyqsNpPj363zkbJh8ckKZxjuPjnnciiJrgwI6K15yGzr9KAicdYgnbK9tiDmcA==@vger.kernel.org X-Gm-Message-State: AOJu0YwIfbZyQPgfGGKkT3dF5zf7KWRPSfVvHItWokqA2tToOc41lv8/ n+6SPy30OWWmzk1OWZulRd4K++fAuSm3UXFEuPmH7BXozjSxGDxD7oPLCzbiw36Neb6jPYXBoZ2 X58hVgp5ETyLqK3c8NbxT9Xe8XsL+2P+YHEpqb2ZcHYEV7DOvqFh4DrJUNPGA7CfhjKe2pDfI X-Gm-Gg: ASbGncue9oeLwC9dA+Y6erAYr179/cUddu8fjv6P8xV2+xvyDuokaZH3IYwwv+yBH0b iM+uLaGJ/ksxS4LfqInc6z6DfuG6lmmJWWIBy3yxaFOYacuSdStXPmYIoKWcXNm8c5/ZvHRv8Hg XMP9/6NauGUQU60DxO7YtDnY4Vldysmf8bfOuP75Qb7oTehK5k8xXMGQnsItuxP76H+1jDo8FFj IqRXjac+FyB2nFp6UvQFTV3eIWbVU5god0992ZPiT1j+Xr+THixl2aZJmnPwY/Wc4Msem3fuhXr QajrS0yK9IqkXgyUv/AGWE4xQU1h0ovxfiDlF4V0hNANLkdHmYXTpHT6nQ9qpTg= X-Received: by 2002:ad4:5fce:0:b0:707:612d:3adb with SMTP id 6a1803df08f44-709d69b2c0emr1134816d6.18.1754927862140; Mon, 11 Aug 2025 08:57:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE83iNLxuXWBRGJIeIFUZHblancM50VRXiEQcjWFBbyuLTm1IZWPJbr6gZfh6Uj5SzS3+J40w== X-Received: by 2002:ad4:5fce:0:b0:707:612d:3adb with SMTP id 6a1803df08f44-709d69b2c0emr1133886d6.18.1754927861515; Mon, 11 Aug 2025 08:57:41 -0700 (PDT) Received: from x1 (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-7077cde5b4esm155566456d6.69.2025.08.11.08.57.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Aug 2025 08:57:40 -0700 (PDT) Date: Mon, 11 Aug 2025 11:57:34 -0400 From: Brian Masney To: Alexander Sverdlin Cc: Michael Turquette , Stephen Boyd , Sudeep Holla , Cristian Marussi , Chen Wang , Inochi Amaoto , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Paul Cercueil , Keguang Zhang , Taichi Sugaya , Takao Orito , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jacky Huang , Shan-Chun Hung , Vladimir Zapolskiy , Piotr Wojtaszczyk , Paul Walmsley , Samuel Holland , Yixun Lan , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Michal Simek , Maxime Ripard , Andreas =?iso-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , Sven Peter , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Eugeniy Paltsev , Ray Jui , Scott Branden , Broadcom internal kernel review list , Max Filippov , Matthias Brugger , AngeloGioacchino Del Regno , Daniel Palmer , Romain Perier , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Bjorn Andersson , Geert Uytterhoeven , Heiko Stuebner , Andrea della Porta , Krzysztof Kozlowski , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Qin Jian , Viresh Kumar , Ulf Hansson , Luca Ceresoli , Alex Helms , Linus Walleij , Liviu Dudau , Lorenzo Pieralisi , Nobuhiro Iwamatsu , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sophgo@lists.linux.dev, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com, linux-actions@lists.infradead.org, asahi@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, soc@lists.linux.dev Subject: Re: [PATCH 048/114] clk: sophgo: sg2042-clkgen: convert from round_rate() to determine_rate() Message-ID: References: <20250811-clk-for-stephen-round-rate-v1-0-b3bf97b038dc@redhat.com> <20250811-clk-for-stephen-round-rate-v1-48-b3bf97b038dc@redhat.com> <9379f132e52c972b2735cad768242cb784b0ed2b.camel@gmail.com> Precedence: bulk X-Mailing-List: linux-samsung-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9379f132e52c972b2735cad768242cb784b0ed2b.camel@gmail.com> User-Agent: Mutt/2.2.14 (2025-02-20) On Mon, Aug 11, 2025 at 05:45:57PM +0200, Alexander Sverdlin wrote: > On Mon, 2025-08-11 at 11:18 -0400, Brian Masney via B4 Relay wrote: > > @@ -192,15 +191,17 @@ static long sg2042_clk_divider_round_rate(struct clk_hw *hw, > >   bestdiv = readl(divider->reg) >> divider->shift; > >   bestdiv &= clk_div_mask(divider->width); > >   } > > - ret_rate = DIV_ROUND_UP_ULL((u64)*prate, bestdiv); > > + ret_rate = DIV_ROUND_UP_ULL((u64)*&req->best_parent_rate, bestdiv); > ^^ > May "*&" be redundand? Yes, I agree that needs dropped and something I missed when I cleaned things up by hand. I verified that this is the only case in this series, and all of the other series that I referenced on the cover letter, where this occurred. My Coccinelle semantic patch has a case when the parent rate is dereferenced, and I'm not sure why that wasn't converted here since it works elsewhere. long round_rate_name(struct clk_hw *hw_param, unsigned long rate_param, unsigned long *parent_rate_param) { <... ( - *parent_rate_param + req->best_parent_rate | - parent_rate_param + &req->best_parent_rate ) ...> } I'll wait a few weeks to send out a v2 to hopefully let big chunks of this series get merged so that I don't have to send out 114 patches again for a v2. Brian