From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans Ulli Kroll Subject: Re: [PATCH 01/15] ARM: kill off set_irq_flags usage Date: Fri, 12 Jun 2015 16:05:48 +0200 (CEST) Message-ID: References: <1433874401-27161-1-git-send-email-robh@kernel.org> <1433874401-27161-2-git-send-email-robh@kernel.org> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from mail-wi0-f182.google.com ([209.85.212.182]:36654 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752847AbbFLOFw (ORCPT ); Fri, 12 Jun 2015 10:05:52 -0400 In-Reply-To: <1433874401-27161-2-git-send-email-robh@kernel.org> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Rob Herring Cc: Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, arm@kernel.org, Sekhar Nori , Kevin Hilman , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Hans Ulli Kroll , Shawn Guo , Sascha Hauer , Imre Kaloz , Krzysztof Halasa , Greg Ungerer , Roland Stigge , Tony Lindgren , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Simtec Linux Team , Kukjin Kim , Krzysztof Kozlowski On Tue, 9 Jun 2015, Rob Herring wrote: > set_irq_flags is ARM specific with custom flags which have genirq > equivalents. Convert drivers to use the genirq interfaces directly, so we > can kill off set_irq_flags. The translation of flags is as follows: > > IRQF_VALID -> !IRQ_NOREQUEST > IRQF_PROBE -> !IRQ_NOPROBE > IRQF_NOAUTOEN -> IRQ_NOAUTOEN > > For IRQs managed by an irqdomain, the irqdomain core code handles clearing > and setting IRQ_NOREQUEST already, so there is no need to do this in > .map() functions and we can simply remove the set_irq_flags calls. Some > users also set IRQ_NOPROBE and this has been maintained although it is not > clear that is really needed. There appears to be a great deal of blind > copy and paste of this code. > for mach-gemini Signed-off-by: Hans Ulli Kroll y