From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Wolfram Sang" <wsa@kernel.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH 62/89] i2c: s3c2410: Convert to platform remove callback returning void
Date: Tue, 9 May 2023 17:09:07 +0200 [thread overview]
Message-ID: <b5f58eb5-eefd-9dc1-91bb-67326be70f98@linaro.org> (raw)
In-Reply-To: <20230508205306.1474415-63-u.kleine-koenig@pengutronix.de>
On 08/05/2023 22:52, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-05-09 15:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 20:51 [PATCH 00/89] i2c: Convert to platform remove callback returning void Uwe Kleine-König
2023-05-08 20:51 ` [PATCH 22/89] i2c: exynos5: " Uwe Kleine-König
2023-05-09 15:08 ` Krzysztof Kozlowski
2023-05-08 20:52 ` [PATCH 62/89] i2c: s3c2410: " Uwe Kleine-König
2023-05-09 15:09 ` Krzysztof Kozlowski [this message]
2023-06-01 7:33 ` [PATCH 00/89] i2c: " Uwe Kleine-König
2023-06-01 7:43 ` Biju Das
2023-06-01 13:54 ` Wolfram Sang
2023-06-05 7:54 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5f58eb5-eefd-9dc1-91bb-67326be70f98@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox