Linux Samsung SOC development
 help / color / mirror / Atom feed
From: Damon Ding <damon.ding@rock-chips.com>
To: "Heiko Stübner" <heiko@sntech.de>,
	andrzej.hajda@intel.com, neil.armstrong@linaro.org,
	rfoss@kernel.org
Cc: Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
	jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com,
	mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com,
	simona@ffwll.ch, shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, inki.dae@samsung.com,
	sw0312.kim@samsung.com, kyungmin.park@samsung.com,
	krzk@kernel.org, alim.akhtar@samsung.com, jingoohan1@gmail.com,
	p.zabel@pengutronix.de, hjc@rock-chips.com,
	andy.yan@rock-chips.com, dmitry.baryshkov@oss.qualcomm.com,
	dianders@chromium.org, m.szyprowski@samsung.com,
	luca.ceresoli@bootlin.com, jani.nikula@intel.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v8 00/18] Apply drm_bridge_connector and panel_bridge helper for the Analogix DP driver
Date: Mon, 2 Feb 2026 09:33:02 +0800	[thread overview]
Message-ID: <c7d2c401-068c-456f-a641-71d9aec9a4cd@rock-chips.com> (raw)
In-Reply-To: <6571983.R56niFO833@diego>

Hi Heiko,

On 1/20/2026 12:06 AM, Heiko Stübner wrote:
> Hi Damon,
> 
> Am Mittwoch, 17. Dezember 2025, 10:33:03 Mitteleuropäische Normalzeit schrieb Damon Ding:
>> PATCH 1 is to ensure the last bridge declares OP_EDID or OP_MODES or both.
>> PATCH 2 is a small format optimization for struct analogid_dp_device.
>> PATCH 3 is to perform mode setting in &drm_bridge_funcs.atomic_enable.
>> PATCH 4 is to add a new parameter to store the point of next bridge.
>> PATCH 5 is to make legacy bridge driver more universal.
>> PATCH 6-11 are preparations for apply drm_bridge_connector helper.
>> PATCH 12 is to apply the drm_bridge_connector helper.
>> PATCH 13-15 are to move the panel/bridge parsing to the Analogix side.
>> PATCH 16 is to attach the next bridge on Analogix side uniformly.
>> PATCH 17-18 are to apply the panel_bridge helper.
> 
> On top of all the recent bridge-related commits, this series still works
> on my rk3588-eDP board - when the display is plugged in on boot.
> 
> As that is the current state we also had before, this series:
> Tested-by: Heiko Stuebner <heiko@sntech.de> on rk3588
> 
> 
> ======
> !!! The following should not hold up this series though, because the
> analogix-dp not handling hotplug, is also the current state already!!!
> ======
> 
> However, actually hotplugging the device does not seem to work.
> 
> With the hpd-gpio inside a dp-connector node.
> 
> 
> (1) When booting connected and unplugging the display I get:
> 
> [   42.725888] rockchip-dp fdec0000.edp: Rx Max Link Rate is abnormal :0 !
> [   42.733325] rockchip-dp fdec0000.edp: Rx Max Lane count is abnormal :0 !
> [   42.764853] rockchip-dp fdec0000.edp: LT link start failed!
> [   42.771105] rockchip-dp fdec0000.edp: eDP link training failed (-110)
> [   42.778329] rockchip-dp fdec0000.edp: unable to do link train, ret=-110
> [   42.785747] [drm:analogix_dp_bridge_atomic_enable] *ERROR* dp commit error, ret = -110
> ( ... repeasts a bunch of times ... )
> [   43.284897] rockchip-dp fdec0000.edp: failed to set bridge, retry: 4
> [   43.292045] rockchip-dp fdec0000.edp: too many times retry set bridge, give it up
> 
> plugging the eDP back in reenables the display successfully though.
> 
> (2) Booting with the display unplugged
> 
> Same messages as above, but plugging the display in for the first time
> does not create an output.
> 
> I'll try to dig more, but if you have an idea, what I should look at, I'd,
> be really grateful.
> 

Sorry for the late reply. I've been heavily occupied with the downstream 
work recently.

I can reproduce the same issue on my RK3576 IOTEST board, which is 
equipped with a standard DP receptacle for eDP interface.

(BTW: The RK3576 Analogix DP functions properly with a set of targeted 
changes, and I plan to upstream these modifications later. :-))

Regarding the eDP HPD exception, several functional patches for HPD 
handling have not yet been synced to the upstream. I will verify these 
changes and submit them when time permits.

Best regards,
Damon


  reply	other threads:[~2026-02-02  8:22 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-17  9:33 [PATCH v8 00/18] Apply drm_bridge_connector and panel_bridge helper for the Analogix DP driver Damon Ding
2025-12-17  9:33 ` [PATCH v8 01/18] drm/display: bridge_connector: Ensure last bridge determines EDID/modes detection capabilities Damon Ding
2025-12-31 10:50   ` Luca Ceresoli
2025-12-17  9:33 ` [PATCH v8 02/18] drm/bridge: analogix_dp: Formalize the struct analogix_dp_device Damon Ding
2026-01-31 12:52   ` Luca Ceresoli
2025-12-17  9:33 ` [PATCH v8 03/18] drm/bridge: analogix_dp: Move &drm_bridge_funcs.mode_set to &drm_bridge_funcs.atomic_enable Damon Ding
2026-01-31 12:50   ` Luca Ceresoli
2025-12-17  9:33 ` [PATCH v8 04/18] drm/bridge: analogix_dp: Add &analogix_dp_plat_data.next_bridge Damon Ding
2025-12-31 11:11   ` Luca Ceresoli
2026-01-04  2:51     ` Damon Ding
2026-01-07  2:36       ` Damon Ding
2026-01-31 13:41         ` Luca Ceresoli
2025-12-17  9:33 ` [PATCH v8 05/18] drm/bridge: Move legacy bridge driver out of imx directory for multi-platform use Damon Ding
2026-01-31 12:33   ` Luca Ceresoli
2026-02-02  2:54     ` Damon Ding
2026-02-03  1:31       ` Damon Ding
2026-02-03 10:11         ` Luca Ceresoli
2026-02-03 14:09           ` Laurent Pinchart
2026-02-04  1:09           ` Damon Ding
2025-12-17  9:33 ` [PATCH v8 06/18] drm/exynos: exynos_dp: Remove &exynos_dp_device.ptn_bridge Damon Ding
2026-01-31 13:41   ` Luca Ceresoli
2025-12-17  9:33 ` [PATCH v8 07/18] drm/exynos: exynos_dp: Remove unused &exynos_dp_device.connector Damon Ding
2026-01-31 13:40   ` Luca Ceresoli
2025-12-17  9:33 ` [PATCH v8 08/18] drm/exynos: exynos_dp: Apply of-display-mode-bridge to parse the display-timings node Damon Ding
2025-12-17  9:33 ` [PATCH v8 09/18] drm/bridge: analogix_dp: Remove redundant &analogix_dp_plat_data.skip_connector Damon Ding
2025-12-17  9:33 ` [PATCH v8 10/18] drm/bridge: analogix_dp: Move the color format check to .atomic_check() for Rockchip platforms Damon Ding
2025-12-17  9:33 ` [PATCH v8 11/18] drm/bridge: analogix_dp: Remove unused &analogix_dp_plat_data.get_modes() Damon Ding
2025-12-17  9:33 ` [PATCH v8 12/18] drm/bridge: analogix_dp: Apply drm_bridge_connector helper Damon Ding
2025-12-17  9:33 ` [PATCH v8 13/18] drm/bridge: analogix_dp: Add new API analogix_dp_finish_probe() Damon Ding
2025-12-17  9:59 ` [PATCH v8 14/18] drm/rockchip: analogix_dp: Apply analogix_dp_finish_probe() Damon Ding
2025-12-17  9:59   ` [PATCH v8 15/18] drm/exynos: exynos_dp: " Damon Ding
2025-12-17  9:59   ` [PATCH v8 16/18] drm/bridge: analogix_dp: Attach the next bridge in analogix_dp_bridge_attach() Damon Ding
2026-01-31 13:34     ` Luca Ceresoli
2025-12-17  9:59   ` [PATCH v8 17/18] drm/bridge: analogix_dp: Remove bridge disabing and panel unpreparing in analogix_dp_unbind() Damon Ding
2025-12-17  9:59   ` [PATCH v8 18/18] drm/bridge: analogix_dp: Apply panel_bridge helper Damon Ding
2026-01-17  7:45 ` [PATCH v8 00/18] Apply drm_bridge_connector and panel_bridge helper for the Analogix DP driver Damon Ding
2026-01-19 16:06 ` Heiko Stübner
2026-02-02  1:33   ` Damon Ding [this message]
2026-02-03 11:11   ` Luca Ceresoli
2026-02-04  1:52     ` Damon Ding
2026-02-03 11:53 ` (subset) " Luca Ceresoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7d2c401-068c-456f-a641-71d9aec9a4cd@rock-chips.com \
    --to=damon.ding@rock-chips.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=alim.akhtar@samsung.com \
    --cc=andrzej.hajda@intel.com \
    --cc=andy.yan@rock-chips.com \
    --cc=dianders@chromium.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=festevam@gmail.com \
    --cc=heiko@sntech.de \
    --cc=hjc@rock-chips.com \
    --cc=imx@lists.linux.dev \
    --cc=inki.dae@samsung.com \
    --cc=jani.nikula@intel.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=jingoohan1@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=kernel@pengutronix.de \
    --cc=krzk@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=m.szyprowski@samsung.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=p.zabel@pengutronix.de \
    --cc=rfoss@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=sw0312.kim@samsung.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox