From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Subject: Re: [PATCH 5/5 v3] iio: exynos_adc: do a reinit_completion before the conversion Date: Thu, 01 May 2014 06:48:19 +0100 Message-ID: References: <1398850015-17761-1-git-send-email-ch.naveen@samsung.com> <1398850015-17761-6-git-send-email-ch.naveen@samsung.com> <536161F5.7090508@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Doug Anderson Cc: Naveen Krishna Chatradhi , linux-iio , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-samsung-soc , Greg Kroah-Hartman , Naveen Krishna , Lars-Peter Clausen , "cpgs ." , Grant Grundler , Tomasz Figa List-Id: linux-samsung-soc@vger.kernel.org On May 1, 2014 12:23:27 AM GMT+01:00, Doug Anderson wrote: >Jonathan, > >On Wed, Apr 30, 2014 at 1:49 PM, Jonathan Cameron >wrote: >> On 30/04/14 10:26, Naveen Krishna Chatradhi wrote: >>> >>> Add reinit_completion() before the wait_for_completion_timeout in >>> raw_read() call. >>> >>> Signed-off-by: Naveen Krishna Chatradhi >>> Reviewed-by: Doug Anderson >> >> Applied to the togreg branch of iio.git >> I wasn't sure if this one was technically a fix, but as it isn't >> marked clearly as such it can go in during the next merge window. >> I won't have pushed this out to a non rebasing branch until tomorrow >> so if this fixes an observed issue then let me know and it might move >> to the fixes-togreg branch. > >As far as I know this doesn't fix an observed issue. I believe it was >requested as part of a previous review and is finally reposted. I >believe it's just extra precautions to make sure that some old IRQ >didn't accidentally complete us between the last transaction and this >one. > >Old discussion is somewhere around here > Thanks for clarifying this. J > >Thanks! > >-Doug -- Sent from my Android phone with K-9 Mail. Please excuse my brevity.