From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Zimmermann Subject: Re: [PATCH v5 18/24] drm/ast: Provide ddc symlink in connector sysfs directory Date: Wed, 24 Jul 2019 19:17:33 +0200 Message-ID: References: <0afab6e2f61907409ba13a0ba91b8ee701eb7d74.1563960855.git.andrzej.p@collabora.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0832753736==" Return-path: In-Reply-To: <0afab6e2f61907409ba13a0ba91b8ee701eb7d74.1563960855.git.andrzej.p@collabora.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Andrzej Pietrasiewicz , dri-devel@lists.freedesktop.org Cc: Neil Armstrong , Maxime Ripard , linux-kernel@vger.kernel.org, Matthias Brugger , Laurent Pinchart , Shawn Guo , kernel@collabora.com, Sam Ravnborg , linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski , Jonathan Hunter , David Airlie , Chen-Yu Tsai , Kukjin Kim , NXP Linux Team , Dave Airlie , Jonas Karlman , linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, Jyri Sarha , Mamta Shukla , linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org, Thomas Gleixner List-Id: linux-samsung-soc@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============0832753736== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rQW7V0pPHkAw2NNiWp7qw2pJTEuWVVZkI" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rQW7V0pPHkAw2NNiWp7qw2pJTEuWVVZkI Content-Type: multipart/mixed; boundary="1nTmnYcXxxfxqvFKU3qpyJbp2Ylpbb6UI"; protected-headers="v1" From: Thomas Zimmermann To: Andrzej Pietrasiewicz , dri-devel@lists.freedesktop.org Cc: Sam Ravnborg , Neil Armstrong , David Airlie , Douglas Anderson , Thierry Reding , Laurent Pinchart , kernel@collabora.com, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Vincent Abriou , Krzysztof Kozlowski , Jonathan Hunter , Maxime Ripard , Chen-Yu Tsai , Kukjin Kim , NXP Linux Team , Dave Airlie , intel-gfx@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org, Jonas Karlman , linux-arm-msm@vger.kernel.org, Mamta Shukla , linux-mediatek@lists.infradead.org, Jyri Sarha , Rodrigo Vivi , Matthias Brugger , Thomas Gleixner , Sean Paul , Pengutronix Kernel Team , Allison Randal , linux-arm-kernel@lists.infradead.org, Enrico Weigelt , Jernej Skrabec , amd-gfx@lists.freedesktop.org, Tomi Valkeinen , Seung-Woo Kim , linux-kernel@vger.kernel.org, Todor Tomov , Kyungmin Park , Huang Rui , Greg Kroah-Hartman , Alex Deucher , Shawn Guo , =?UTF-8?Q?Christian_K=c3=b6nig?= , Gerd Hoffmann Message-ID: Subject: Re: [PATCH v5 18/24] drm/ast: Provide ddc symlink in connector sysfs directory References: <0afab6e2f61907409ba13a0ba91b8ee701eb7d74.1563960855.git.andrzej.p@collabora.com> In-Reply-To: <0afab6e2f61907409ba13a0ba91b8ee701eb7d74.1563960855.git.andrzej.p@collabora.com> --1nTmnYcXxxfxqvFKU3qpyJbp2Ylpbb6UI Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 24.07.19 um 15:59 schrieb Andrzej Pietrasiewicz: > Use the ddc pointer provided by the generic connector. >=20 > Signed-off-by: Andrzej Pietrasiewicz > --- > drivers/gpu/drm/ast/ast_mode.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_m= ode.c > index c792362024a5..1c899a6e87b7 100644 > --- a/drivers/gpu/drm/ast/ast_mode.c > +++ b/drivers/gpu/drm/ast/ast_mode.c > @@ -867,7 +867,14 @@ static int ast_connector_init(struct drm_device *d= ev) > return -ENOMEM; > =20 > connector =3D &ast_connector->base; > - drm_connector_init(dev, connector, &ast_connector_funcs, DRM_MODE_CON= NECTOR_VGA); > + ast_connector->i2c =3D ast_i2c_create(dev); > + if (!ast_connector->i2c) > + DRM_ERROR("failed to add ddc bus for connector\n"); > + > + drm_connector_init_with_ddc(dev, connector, > + &ast_connector_funcs, > + DRM_MODE_CONNECTOR_VGA, > + &ast_connector->i2c->adapter); > =20 > drm_connector_helper_add(connector, &ast_connector_helper_funcs); > =20 > @@ -881,10 +888,6 @@ static int ast_connector_init(struct drm_device *d= ev) > encoder =3D list_first_entry(&dev->mode_config.encoder_list, struct d= rm_encoder, head); > drm_connector_attach_encoder(connector, encoder); > =20 > - ast_connector->i2c =3D ast_i2c_create(dev); > - if (!ast_connector->i2c) > - DRM_ERROR("failed to add ddc bus for connector\n"); > - > return 0; > } > =20 >=20 Reviewed-by: Thomas Zimmermann --=20 Thomas Zimmermann Graphics Driver Developer SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany GF: Felix Imend=C3=B6rffer, Mary Higgins, Sri Rasiah HRB 21284 (AG N=C3=BCrnberg) --1nTmnYcXxxfxqvFKU3qpyJbp2Ylpbb6UI-- --rQW7V0pPHkAw2NNiWp7qw2pJTEuWVVZkI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEchf7rIzpz2NEoWjlaA3BHVMLeiMFAl04kq0ACgkQaA3BHVML eiOVlgf9G4jOeCy2mr53PWbrCulWova4UboUrbdUc7gRFOmPd+B+OzGYuSRcUnlg kOVXCeSAueui+sQ0IbNuz/aH/ObT+dZzXd5gkLN9J6jj1WoLQ8Wyn4apJy13rnsE mHtW7wjvJ8kq5Yool9NZApYN9aD6ZTxZQwt4YokeS7Kfryf+vQN3pweb8XGBW3d4 FuLKHRSrgcqTY1XUMAbXlEC5A0DfBo4wfar1q7u045ggLL84yMQcw3SJ9WyiPbpf k2v9fkgpwy60HTlNaTBxlzm4KBoRVXfYqIynlK3QMf7GF2sz0RiBF2RmzgG96f0I UqpER9GagpcIV5uY52PywoarGEUWuA== =lXB9 -----END PGP SIGNATURE----- --rQW7V0pPHkAw2NNiWp7qw2pJTEuWVVZkI-- --===============0832753736== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 --===============0832753736==--