Linux Samsung SOC development
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Tudor Ambarus <tudor.ambarus@linaro.org>,
	Peter Griffin <peter.griffin@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, andre.draszik@linaro.org,
	kernel-team@android.com, willmcvicker@google.com,
	daniel.lezcano@linaro.org, vincent.guittot@linaro.org,
	ulf.hansson@linaro.org, arnd@arndb.de,
	Jassi Brar <jassisinghbrar@gmail.com>
Subject: Re: [PATCH v3 2/4] arm64: dts: exynos: gs101: add AP to APM mailbox node
Date: Sun, 22 Dec 2024 12:47:15 +0100	[thread overview]
Message-ID: <f5e3d00e-8f98-46c6-8f1a-85a2169324ee@kernel.org> (raw)
In-Reply-To: <20241220-gs101-acpm-dt-v3-2-642d64daa5d1@linaro.org>

On 20/12/2024 15:45, Tudor Ambarus wrote:
> GS101 has 14 mailbox controllers. Add the AP to APM mailbox node.
> 
> Mailbox controllers have a shared register that can be used for passing
> the mailbox messages. The AP to APM mailbox controller is used just as a
> doorbell mechanism. It raises interrupt to the firmware after the mailbox
> message has been written to SRAM where the TX/RX rings are defined.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---
>  arch/arm64/boot/dts/exynos/google/gs101.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> index 1441e9a252c2..6947dd081a0e 100644
> --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> @@ -1445,6 +1445,15 @@ wakeup-interrupt-controller {
>  			};
>  		};
>  
> +		ap2apm_mailbox: mailbox@17610000 {
> +			compatible = "google,gs101-mbox";


I don't think I have this in my tree and cover letter does not explain
where I can find bindings. Nothing in next from few days ago. Always
document in DTS patchset where are the bindings, unless it's obvious.

Best regards,
Krzysztof

  reply	other threads:[~2024-12-22 14:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-20 14:45 [PATCH v3 0/4] arm64: exynos: gs101: add ACPM related nodes Tudor Ambarus
2024-12-20 14:45 ` [PATCH v3 1/4] arm64: dts: exynos: gs101: add SRAM node Tudor Ambarus
2024-12-20 14:45 ` [PATCH v3 2/4] arm64: dts: exynos: gs101: add AP to APM mailbox node Tudor Ambarus
2024-12-22 11:47   ` Krzysztof Kozlowski [this message]
2024-12-30  9:33     ` Tudor Ambarus
2024-12-20 14:45 ` [PATCH v3 3/4] arm64: dts: exynos: gs101: add ACPM protocol node Tudor Ambarus
2024-12-20 14:45 ` [PATCH v3 4/4] arm64: defconfig: enable ACPM protocol and Exynos mailbox Tudor Ambarus
2024-12-29 10:00 ` [PATCH v3 0/4] arm64: exynos: gs101: add ACPM related nodes Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f5e3d00e-8f98-46c6-8f1a-85a2169324ee@kernel.org \
    --to=krzk@kernel.org \
    --cc=alim.akhtar@samsung.com \
    --cc=andre.draszik@linaro.org \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jassisinghbrar@gmail.com \
    --cc=kernel-team@android.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=peter.griffin@linaro.org \
    --cc=robh@kernel.org \
    --cc=tudor.ambarus@linaro.org \
    --cc=ulf.hansson@linaro.org \
    --cc=vincent.guittot@linaro.org \
    --cc=will@kernel.org \
    --cc=willmcvicker@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox