From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>,
Denzeel Oliva <wachiturroxd150@gmail.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: Add initial support for Samsung Galaxy S20 FE (r8s)
Date: Mon, 2 Dec 2024 09:56:37 +0100 [thread overview]
Message-ID: <f8780a3a-793a-4067-8108-18a293eb1fd0@kernel.org> (raw)
In-Reply-To: <746e218b-a00c-49ac-a998-511696bc9525@gmail.com>
On 14/11/2024 09:26, Ivaylo Ivanov wrote:
>
>
>
> On 11/12/24 21:31, Denzeel Oliva wrote:
>> Add initial support for the Samsung Galaxy S20 FE (r8s/SM-G780F) device.
>> Its launch was in 2020 and also based on the Exynos 990 SoC.
>> It is only configured with 6GB of RAM, although storage options may differ.
>
> As far as I can tell, there are models with more than 6gb's of ram.
> How would the memory node differ for them?
>
Denzeel,
This comment was not addressed.
Be sure you respond to reviewers in timely manner (and if you give
yourself more than two weeks to respond it also means other have more
than two weeks...).
Nevertheless, this is not really stopping from merging this device. New
variants can be always later added with different memory map.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-12-02 8:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 19:31 [PATCH v2 0/2] Add support for Samsung Galaxy S20 FE (SM-G780F/r8s) [SoC Exynos990] Denzeel Oliva
2024-11-12 19:31 ` [PATCH v2 1/2] dt-bindings: arm: samsung: Add compatible for Samsung Galaxy S20 FE (SM-G780F) Denzeel Oliva
2024-11-12 19:31 ` [PATCH v2 2/2] arm64: dts: Add initial support for Samsung Galaxy S20 FE (r8s) Denzeel Oliva
2024-11-14 8:26 ` Ivaylo Ivanov
2024-12-02 8:56 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8780a3a-793a-4067-8108-18a293eb1fd0@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ivo.ivanov.ivanov1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=wachiturroxd150@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox