public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: "Kiwoong Kim" <kwmad.kim@samsung.com>
To: <linux-scsi@vger.kernel.org>, <alim.akhtar@samsung.com>,
	<avri.altman@wdc.com>, <jejb@linux.ibm.com>,
	<martin.petersen@oracle.com>, <beanhuo@micron.com>,
	<cang@codeaurora.org>, <adrian.hunter@intel.com>,
	<sc.suh@samsung.com>, <hy50.seo@samsung.com>,
	<sh425.lee@samsung.com>, <bhoon95.kim@samsung.com>
Subject: About reading UECxx in ufshcd_dump_regs
Date: Sat, 5 Feb 2022 16:05:14 +0900	[thread overview]
Message-ID: <000001d81a5e$b9907610$2cb16230$@samsung.com> (raw)
In-Reply-To: CGME20220205070515epcas2p324076e473ad0d955f43fdb3cb409c584@epcas2p3.samsung.com

Dear all

I want to discuss about reading UECxx of UFS SFRs in ufshcd_dump_regs.

There are five SFRs - UECPA, UECDL, UECN, UECT and UECDME which are all ROC type that means they are cleared when reading them.
Originally, these SFRs are to let UFS driver know UIC error type which a UIC errors occurs.
Thus, when UFS driver reads them after clearing IS.UE, they are cleared.

I think the read values would be zero in many cases because of the flow I mentioned
And there might be some cases when ufshcd_dump_regs reads them before the ISR reads them.
e.g. when a command is timed out and ufshcd_dump_regs is called in ufshcd_abort.

So I want to ask this: how about removing reading UECxx in ufshcd_dump_regs?
I think reading them is meaningless and might be even a little bit risky.

Thanks.
Kiwoong Kim



       reply	other threads:[~2022-02-05  7:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220205070515epcas2p324076e473ad0d955f43fdb3cb409c584@epcas2p3.samsung.com>
2022-02-05  7:05 ` Kiwoong Kim [this message]
2022-02-06  8:22   ` About reading UECxx in ufshcd_dump_regs Avri Altman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000001d81a5e$b9907610$2cb16230$@samsung.com' \
    --to=kwmad.kim@samsung.com \
    --cc=adrian.hunter@intel.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=bhoon95.kim@samsung.com \
    --cc=cang@codeaurora.org \
    --cc=hy50.seo@samsung.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=sc.suh@samsung.com \
    --cc=sh425.lee@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox