From mboxrd@z Thu Jan 1 00:00:00 1970 From: Seungwon Jeon Subject: RE: [PATCH v4 1/6] scsi: ufs: wrap the i/o access operations Date: Thu, 09 May 2013 15:39:28 +0900 Message-ID: <000901ce4c7f$f47fd920$dd7f8b60$%jun@samsung.com> References: <1366812872-26331-1-git-send-email-sthumma@codeaurora.org> <001e01ce4105$ab4e2430$01ea6c90$%jun@samsung.com> <000b01ce48a3$ad7072e0$085158a0$%jun@samsung.com> <002401ce4bc7$cda068a0$68e139e0$%jun@samsung.com> <000201ce4c58$e3bc3b00$ab34b100$%jun@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout4.samsung.com ([203.254.224.34]:47834 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750704Ab3EIGjg (ORCPT ); Thu, 9 May 2013 02:39:36 -0400 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MMI00MMXQHSNIR0@mailout4.samsung.com> for linux-scsi@vger.kernel.org; Thu, 09 May 2013 15:39:29 +0900 (KST) In-reply-to: Content-language: ko Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: 'Santosh Y' Cc: "'James E.J. Bottomley'" , linux-scsi@vger.kernel.org, 'Vinayak Holikatti' On Thursday, May 09, 2013 Santosh wrote: > > There are two patches remained. These are applied with your final comments. > > Do you have any idea? > > [PATCH v4 5/6] scsi: ufs: add dme configuration primitives > > [PATCH v4 6/6] scsi: ufs: add dme control primitives > > > > Since there is no use case for these implementations yet, except for > ufshcd_get_dme_attr_val(), as per James's suggestion > [http://www.mail-archive.com/linux-scsi@vger.kernel.org/msg20207.html] > I did not ACK the patches. > The same patches can be used to implement related features and resubmit later. I respect your decision. But I have another opinion. The remained patches are basic operations which should be supported by ufshcd. Especially, dme_set/set will be used in vender specific part of host controller rather than in ufshcd itself. And above all, Maya Erez completed to test and reported working fine. If these patches are merged this time, it would be helpful to various hosts. Thanks, Seungwon Jeon > > -- > ~Santosh > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html