* [PATCH 00/20] [SCSI] remove unnecessary pci_set_drvdata()
@ 2013-09-23 0:54 Jingoo Han
2013-09-23 0:55 ` [PATCH 01/20] [SCSI] lpfc 8.3.42: " Jingoo Han
` (20 more replies)
0 siblings, 21 replies; 24+ messages in thread
From: Jingoo Han @ 2013-09-23 0:54 UTC (permalink / raw)
To: 'James Bottomley'; +Cc: linux-scsi, 'Jingoo Han'
Since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound),
the driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
---
drivers/scsi/arcmsr/arcmsr_hba.c | 1 -
drivers/scsi/atp870u.c | 2 --
drivers/scsi/bfa/bfad.c | 1 -
drivers/scsi/csiostor/csio_init.c | 2 --
drivers/scsi/dc395x.c | 1 -
drivers/scsi/fnic/fnic_main.c | 1 -
drivers/scsi/gdth.c | 2 --
drivers/scsi/hpsa.c | 1 -
drivers/scsi/lpfc/lpfc_init.c | 3 ---
drivers/scsi/megaraid/megaraid_mbox.c | 6 ------
drivers/scsi/megaraid/megaraid_sas_base.c | 5 -----
drivers/scsi/mvsas/mv_init.c | 1 -
drivers/scsi/mvumi.c | 2 --
drivers/scsi/pm8001/pm8001_init.c | 1 -
drivers/scsi/pmcraid.c | 1 -
drivers/scsi/qla2xxx/qla_os.c | 1 -
drivers/scsi/qla4xxx/ql4_os.c | 1 -
drivers/scsi/stex.c | 2 --
drivers/scsi/tmscsim.c | 1 -
drivers/scsi/ufs/ufshcd-pci.c | 1 -
drivers/scsi/vmw_pvscsi.c | 2 --
21 files changed, 38 deletions(-)
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 01/20] [SCSI] lpfc 8.3.42: remove unnecessary pci_set_drvdata()
2013-09-23 0:54 [PATCH 00/20] [SCSI] remove unnecessary pci_set_drvdata() Jingoo Han
@ 2013-09-23 0:55 ` Jingoo Han
2013-09-23 0:57 ` [PATCH 02/20] [SCSI] arcmsr: " Jingoo Han
` (19 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: Jingoo Han @ 2013-09-23 0:55 UTC (permalink / raw)
To: 'James Bottomley'
Cc: linux-scsi, 'James Smart', 'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/scsi/lpfc/lpfc_init.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index 647f5bf..3dfd38c 100644
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -4581,8 +4581,6 @@ lpfc_disable_pci_dev(struct lpfc_hba *phba)
/* Release PCI resource and disable PCI device */
pci_release_selected_regions(pdev, bars);
pci_disable_device(pdev);
- /* Null out PCI private reference to driver */
- pci_set_drvdata(pdev, NULL);
return;
}
@@ -9429,7 +9427,6 @@ lpfc_pci_remove_one_s3(struct pci_dev *pdev)
/* Disable interrupt */
lpfc_sli_disable_intr(phba);
- pci_set_drvdata(pdev, NULL);
scsi_host_put(shost);
/*
--
1.7.10.4
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 02/20] [SCSI] arcmsr: remove unnecessary pci_set_drvdata()
2013-09-23 0:54 [PATCH 00/20] [SCSI] remove unnecessary pci_set_drvdata() Jingoo Han
2013-09-23 0:55 ` [PATCH 01/20] [SCSI] lpfc 8.3.42: " Jingoo Han
@ 2013-09-23 0:57 ` Jingoo Han
2013-09-23 0:58 ` [PATCH 03/20] [SCSI] atp870u: " Jingoo Han
` (18 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: Jingoo Han @ 2013-09-23 0:57 UTC (permalink / raw)
To: 'James Bottomley'
Cc: linux-scsi, 'Jingoo Han', 'Nick Cheng'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/scsi/arcmsr/arcmsr_hba.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
index 33c52bc..97fd450 100644
--- a/drivers/scsi/arcmsr/arcmsr_hba.c
+++ b/drivers/scsi/arcmsr/arcmsr_hba.c
@@ -1035,7 +1035,6 @@ static void arcmsr_remove(struct pci_dev *pdev)
pci_release_regions(pdev);
scsi_host_put(host);
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
}
static void arcmsr_shutdown(struct pci_dev *pdev)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 03/20] [SCSI] atp870u: remove unnecessary pci_set_drvdata()
2013-09-23 0:54 [PATCH 00/20] [SCSI] remove unnecessary pci_set_drvdata() Jingoo Han
2013-09-23 0:55 ` [PATCH 01/20] [SCSI] lpfc 8.3.42: " Jingoo Han
2013-09-23 0:57 ` [PATCH 02/20] [SCSI] arcmsr: " Jingoo Han
@ 2013-09-23 0:58 ` Jingoo Han
2013-09-23 0:59 ` [PATCH 04/20] [SCSI] bfa: " Jingoo Han
` (17 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: Jingoo Han @ 2013-09-23 0:58 UTC (permalink / raw)
To: 'James Bottomley'; +Cc: linux-scsi, 'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/scsi/atp870u.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/atp870u.c b/drivers/scsi/atp870u.c
index 15a629d..a795d81 100644
--- a/drivers/scsi/atp870u.c
+++ b/drivers/scsi/atp870u.c
@@ -3144,8 +3144,6 @@ static void atp870u_remove (struct pci_dev *pdev)
atp870u_free_tables(pshost);
printk(KERN_INFO "scsi_host_put : %p\n",pshost);
scsi_host_put(pshost);
- printk(KERN_INFO "pci_set_drvdata : %p\n",pdev);
- pci_set_drvdata(pdev, NULL);
}
MODULE_LICENSE("GPL");
--
1.7.10.4
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 04/20] [SCSI] bfa: remove unnecessary pci_set_drvdata()
2013-09-23 0:54 [PATCH 00/20] [SCSI] remove unnecessary pci_set_drvdata() Jingoo Han
` (2 preceding siblings ...)
2013-09-23 0:58 ` [PATCH 03/20] [SCSI] atp870u: " Jingoo Han
@ 2013-09-23 0:59 ` Jingoo Han
2013-09-23 1:00 ` [PATCH 05/20] [SCSI] csiostor: " Jingoo Han
` (16 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: Jingoo Han @ 2013-09-23 0:59 UTC (permalink / raw)
To: 'James Bottomley'
Cc: linux-scsi, 'Jingoo Han', 'Anil Gurumurthy',
'Vijaya Mohan Guvva'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/scsi/bfa/bfad.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/bfa/bfad.c b/drivers/scsi/bfa/bfad.c
index f8ca7be..2e6e3ac 100644
--- a/drivers/scsi/bfa/bfad.c
+++ b/drivers/scsi/bfa/bfad.c
@@ -833,7 +833,6 @@ bfad_pci_uninit(struct pci_dev *pdev, struct bfad_s *bfad)
/* Disable PCIE Advanced Error Recovery (AER) */
pci_disable_pcie_error_reporting(pdev);
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
}
bfa_status_t
--
1.7.10.4
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 05/20] [SCSI] csiostor: remove unnecessary pci_set_drvdata()
2013-09-23 0:54 [PATCH 00/20] [SCSI] remove unnecessary pci_set_drvdata() Jingoo Han
` (3 preceding siblings ...)
2013-09-23 0:59 ` [PATCH 04/20] [SCSI] bfa: " Jingoo Han
@ 2013-09-23 1:00 ` Jingoo Han
2013-09-23 1:01 ` [PATCH 06/20] [SCSI] fnic: " Jingoo Han
` (15 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: Jingoo Han @ 2013-09-23 1:00 UTC (permalink / raw)
To: 'James Bottomley'
Cc: linux-scsi, 'Jingoo Han', 'Naresh Kumar Inna',
'Arvind Bhushan'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/scsi/csiostor/csio_init.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/csiostor/csio_init.c b/drivers/scsi/csiostor/csio_init.c
index 00346fe..1aafc33 100644
--- a/drivers/scsi/csiostor/csio_init.c
+++ b/drivers/scsi/csiostor/csio_init.c
@@ -1010,7 +1010,6 @@ err_lnode_exit:
csio_hw_stop(hw);
spin_unlock_irq(&hw->lock);
csio_lnodes_unblock_request(hw);
- pci_set_drvdata(hw->pdev, NULL);
csio_lnodes_exit(hw, 0);
csio_hw_free(hw);
err_pci_exit:
@@ -1044,7 +1043,6 @@ static void csio_remove_one(struct pci_dev *pdev)
csio_lnodes_exit(hw, 0);
csio_hw_free(hw);
- pci_set_drvdata(pdev, NULL);
csio_pci_exit(pdev, &bars);
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 06/20] [SCSI] fnic: remove unnecessary pci_set_drvdata()
2013-09-23 0:54 [PATCH 00/20] [SCSI] remove unnecessary pci_set_drvdata() Jingoo Han
` (4 preceding siblings ...)
2013-09-23 1:00 ` [PATCH 05/20] [SCSI] csiostor: " Jingoo Han
@ 2013-09-23 1:01 ` Jingoo Han
2013-09-23 1:02 ` [PATCH 07/20] [SCSI] gdth: " Jingoo Han
` (14 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: Jingoo Han @ 2013-09-23 1:01 UTC (permalink / raw)
To: 'James Bottomley'
Cc: linux-scsi, 'Jingoo Han', 'Hiral Patel',
'Suma Ramars', 'Brian Uchino'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/scsi/fnic/fnic_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/fnic/fnic_main.c b/drivers/scsi/fnic/fnic_main.c
index bbf81ea..889b594 100644
--- a/drivers/scsi/fnic/fnic_main.c
+++ b/drivers/scsi/fnic/fnic_main.c
@@ -996,7 +996,6 @@ static void fnic_remove(struct pci_dev *pdev)
fnic_iounmap(fnic);
pci_release_regions(pdev);
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
scsi_host_put(lp->host);
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 07/20] [SCSI] gdth: remove unnecessary pci_set_drvdata()
2013-09-23 0:54 [PATCH 00/20] [SCSI] remove unnecessary pci_set_drvdata() Jingoo Han
` (5 preceding siblings ...)
2013-09-23 1:01 ` [PATCH 06/20] [SCSI] fnic: " Jingoo Han
@ 2013-09-23 1:02 ` Jingoo Han
2013-09-23 1:03 ` [PATCH 08/20] [SCSI] hpsa: " Jingoo Han
` (13 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: Jingoo Han @ 2013-09-23 1:02 UTC (permalink / raw)
To: 'James Bottomley'
Cc: linux-scsi, 'Jingoo Han', 'Achim Leubner'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/scsi/gdth.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
index 6d55b4e..ee4fa40 100644
--- a/drivers/scsi/gdth.c
+++ b/drivers/scsi/gdth.c
@@ -594,8 +594,6 @@ static void gdth_pci_remove_one(struct pci_dev *pdev)
{
gdth_ha_str *ha = pci_get_drvdata(pdev);
- pci_set_drvdata(pdev, NULL);
-
list_del(&ha->list);
gdth_remove_one(ha);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 08/20] [SCSI] hpsa: remove unnecessary pci_set_drvdata()
2013-09-23 0:54 [PATCH 00/20] [SCSI] remove unnecessary pci_set_drvdata() Jingoo Han
` (6 preceding siblings ...)
2013-09-23 1:02 ` [PATCH 07/20] [SCSI] gdth: " Jingoo Han
@ 2013-09-23 1:03 ` Jingoo Han
2013-09-23 1:03 ` [PATCH 09/20] [SCSI] megaraid: " Jingoo Han
` (12 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: Jingoo Han @ 2013-09-23 1:03 UTC (permalink / raw)
To: 'James Bottomley'
Cc: linux-scsi, 'Jingoo Han', 'Stephen M. Cameron'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/scsi/hpsa.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 891c86b..df72d4a 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -5018,7 +5018,6 @@ static void hpsa_remove_one(struct pci_dev *pdev)
kfree(h->hba_inquiry_data);
pci_disable_device(pdev);
pci_release_regions(pdev);
- pci_set_drvdata(pdev, NULL);
kfree(h);
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 09/20] [SCSI] megaraid: remove unnecessary pci_set_drvdata()
2013-09-23 0:54 [PATCH 00/20] [SCSI] remove unnecessary pci_set_drvdata() Jingoo Han
` (7 preceding siblings ...)
2013-09-23 1:03 ` [PATCH 08/20] [SCSI] hpsa: " Jingoo Han
@ 2013-09-23 1:03 ` Jingoo Han
2013-09-23 1:05 ` [PATCH 10/20] [SCSI] mvumi: " Jingoo Han
` (11 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: Jingoo Han @ 2013-09-23 1:03 UTC (permalink / raw)
To: 'James Bottomley'
Cc: linux-scsi, 'Jingoo Han', 'Neela Syam Kolli'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/scsi/megaraid/megaraid_mbox.c | 6 ------
drivers/scsi/megaraid/megaraid_sas_base.c | 5 -----
2 files changed, 11 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_mbox.c b/drivers/scsi/megaraid/megaraid_mbox.c
index 515c962..d1a4b82 100644
--- a/drivers/scsi/megaraid/megaraid_mbox.c
+++ b/drivers/scsi/megaraid/megaraid_mbox.c
@@ -534,7 +534,6 @@ megaraid_probe_one(struct pci_dev *pdev, const struct pci_device_id *id)
return 0;
out_cmm_unreg:
- pci_set_drvdata(pdev, NULL);
megaraid_cmm_unregister(adapter);
out_fini_mbox:
megaraid_fini_mbox(adapter);
@@ -594,11 +593,6 @@ megaraid_detach_one(struct pci_dev *pdev)
// detach from the IO sub-system
megaraid_io_detach(adapter);
- // reset the device state in the PCI structure. We check this
- // condition when we enter here. If the device state is NULL,
- // that would mean the device has already been removed
- pci_set_drvdata(pdev, NULL);
-
// Unregister from common management module
//
// FIXME: this must return success or failure for conditions if there
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index 3020921..a6efc1e 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -4449,7 +4449,6 @@ retry_irq_register:
megasas_mgmt_info.instance[megasas_mgmt_info.max_index] = NULL;
megasas_mgmt_info.max_index--;
- pci_set_drvdata(pdev, NULL);
instance->instancet->disable_intr(instance);
if (instance->msix_vectors)
for (i = 0 ; i < instance->msix_vectors; i++)
@@ -4805,8 +4804,6 @@ static void megasas_detach_one(struct pci_dev *pdev)
}
}
- pci_set_drvdata(instance->pdev, NULL);
-
instance->instancet->disable_intr(instance);
if (instance->msix_vectors)
@@ -4848,8 +4845,6 @@ static void megasas_detach_one(struct pci_dev *pdev)
instance->evt_detail, instance->evt_detail_h);
scsi_host_put(host);
- pci_set_drvdata(pdev, NULL);
-
pci_disable_device(pdev);
return;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 10/20] [SCSI] mvumi: remove unnecessary pci_set_drvdata()
2013-09-23 0:54 [PATCH 00/20] [SCSI] remove unnecessary pci_set_drvdata() Jingoo Han
` (8 preceding siblings ...)
2013-09-23 1:03 ` [PATCH 09/20] [SCSI] megaraid: " Jingoo Han
@ 2013-09-23 1:05 ` Jingoo Han
2013-09-23 1:06 ` [PATCH 11/20] [SCSI] mvsas: " Jingoo Han
` (10 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: Jingoo Han @ 2013-09-23 1:05 UTC (permalink / raw)
To: 'James Bottomley'
Cc: linux-scsi, 'Jingoo Han', 'Myron Stowe'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/scsi/mvumi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/mvumi.c b/drivers/scsi/mvumi.c
index d0b6a03..3206ba3 100644
--- a/drivers/scsi/mvumi.c
+++ b/drivers/scsi/mvumi.c
@@ -2583,7 +2583,6 @@ static int mvumi_probe_one(struct pci_dev *pdev, const struct pci_device_id *id)
return 0;
fail_io_attach:
- pci_set_drvdata(pdev, NULL);
mhba->instancet->disable_intr(mhba);
free_irq(mhba->pdev->irq, mhba);
fail_init_irq:
@@ -2618,7 +2617,6 @@ static void mvumi_detach_one(struct pci_dev *pdev)
free_irq(mhba->pdev->irq, mhba);
mvumi_release_fw(mhba);
scsi_host_put(host);
- pci_set_drvdata(pdev, NULL);
pci_disable_device(pdev);
dev_dbg(&pdev->dev, "driver is removed!\n");
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 11/20] [SCSI] mvsas: remove unnecessary pci_set_drvdata()
2013-09-23 0:54 [PATCH 00/20] [SCSI] remove unnecessary pci_set_drvdata() Jingoo Han
` (9 preceding siblings ...)
2013-09-23 1:05 ` [PATCH 10/20] [SCSI] mvumi: " Jingoo Han
@ 2013-09-23 1:06 ` Jingoo Han
2013-09-23 1:08 ` [PATCH 12/20] [SCSI] pm80xx: " Jingoo Han
` (9 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: Jingoo Han @ 2013-09-23 1:06 UTC (permalink / raw)
To: 'James Bottomley'
Cc: linux-scsi, 'Jingoo Han', 'Myron Stowe'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/scsi/mvsas/mv_init.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/mvsas/mv_init.c b/drivers/scsi/mvsas/mv_init.c
index 7b7381d..5ff978b 100644
--- a/drivers/scsi/mvsas/mv_init.c
+++ b/drivers/scsi/mvsas/mv_init.c
@@ -657,7 +657,6 @@ static void mvs_pci_remove(struct pci_dev *pdev)
tasklet_kill(&((struct mvs_prv_info *)sha->lldd_ha)->mv_tasklet);
#endif
- pci_set_drvdata(pdev, NULL);
sas_unregister_ha(sha);
sas_remove_host(mvi->shost);
scsi_remove_host(mvi->shost);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 12/20] [SCSI] pm80xx: remove unnecessary pci_set_drvdata()
2013-09-23 0:54 [PATCH 00/20] [SCSI] remove unnecessary pci_set_drvdata() Jingoo Han
` (10 preceding siblings ...)
2013-09-23 1:06 ` [PATCH 11/20] [SCSI] mvsas: " Jingoo Han
@ 2013-09-23 1:08 ` Jingoo Han
2013-09-23 1:09 ` [PATCH 13/20] [SCSI] pmcraid: " Jingoo Han
` (8 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: Jingoo Han @ 2013-09-23 1:08 UTC (permalink / raw)
To: 'James Bottomley'
Cc: linux-scsi, 'Jingoo Han', 'Lindar Liu',
'Jack Wang'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/scsi/pm8001/pm8001_init.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c
index f7c1896..0dba7c7 100644
--- a/drivers/scsi/pm8001/pm8001_init.c
+++ b/drivers/scsi/pm8001/pm8001_init.c
@@ -873,7 +873,6 @@ static void pm8001_pci_remove(struct pci_dev *pdev)
struct pm8001_hba_info *pm8001_ha;
int i;
pm8001_ha = sha->lldd_ha;
- pci_set_drvdata(pdev, NULL);
sas_unregister_ha(sha);
sas_remove_host(pm8001_ha->shost);
list_del(&pm8001_ha->list);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 13/20] [SCSI] pmcraid: remove unnecessary pci_set_drvdata()
2013-09-23 0:54 [PATCH 00/20] [SCSI] remove unnecessary pci_set_drvdata() Jingoo Han
` (11 preceding siblings ...)
2013-09-23 1:08 ` [PATCH 12/20] [SCSI] pm80xx: " Jingoo Han
@ 2013-09-23 1:09 ` Jingoo Han
2013-09-23 1:10 ` [PATCH 14/20] [SCSI] qla2xxx: " Jingoo Han
` (7 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: Jingoo Han @ 2013-09-23 1:09 UTC (permalink / raw)
To: 'James Bottomley'
Cc: linux-scsi, 'Jingoo Han', 'Anil Ravindranath'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/scsi/pmcraid.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
index 1eb7b028..e43db77 100644
--- a/drivers/scsi/pmcraid.c
+++ b/drivers/scsi/pmcraid.c
@@ -6049,7 +6049,6 @@ out_release_regions:
out_disable_device:
atomic_dec(&pmcraid_adapter_count);
- pci_set_drvdata(pdev, NULL);
pci_disable_device(pdev);
return -ENODEV;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 14/20] [SCSI] qla2xxx: remove unnecessary pci_set_drvdata()
2013-09-23 0:54 [PATCH 00/20] [SCSI] remove unnecessary pci_set_drvdata() Jingoo Han
` (12 preceding siblings ...)
2013-09-23 1:09 ` [PATCH 13/20] [SCSI] pmcraid: " Jingoo Han
@ 2013-09-23 1:10 ` Jingoo Han
2013-09-23 1:11 ` [PATCH 15/20] [SCSI] qla4xxx: " Jingoo Han
` (6 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: Jingoo Han @ 2013-09-23 1:10 UTC (permalink / raw)
To: 'James Bottomley'
Cc: linux-scsi, 'Jingoo Han', 'Andrew Vasquez'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/scsi/qla2xxx/qla_os.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index 9f01bbb..1db4819 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -3183,7 +3183,6 @@ qla2x00_remove_one(struct pci_dev *pdev)
pci_disable_pcie_error_reporting(pdev);
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
}
static void
--
1.7.10.4
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 15/20] [SCSI] qla4xxx: remove unnecessary pci_set_drvdata()
2013-09-23 0:54 [PATCH 00/20] [SCSI] remove unnecessary pci_set_drvdata() Jingoo Han
` (13 preceding siblings ...)
2013-09-23 1:10 ` [PATCH 14/20] [SCSI] qla2xxx: " Jingoo Han
@ 2013-09-23 1:11 ` Jingoo Han
2013-09-23 1:12 ` [PATCH 16/20] [SCSI] stex: " Jingoo Han
` (5 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: Jingoo Han @ 2013-09-23 1:11 UTC (permalink / raw)
To: 'James Bottomley'
Cc: linux-scsi, 'Jingoo Han', 'Vikas Chaudhary'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/scsi/qla4xxx/ql4_os.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
index f8a0a26..1be6cef 100644
--- a/drivers/scsi/qla4xxx/ql4_os.c
+++ b/drivers/scsi/qla4xxx/ql4_os.c
@@ -7400,7 +7400,6 @@ static void qla4xxx_remove_adapter(struct pci_dev *pdev)
pci_disable_pcie_error_reporting(pdev);
pci_disable_device(pdev);
- pci_set_drvdata(pdev, NULL);
}
/**
--
1.7.10.4
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 16/20] [SCSI] stex: remove unnecessary pci_set_drvdata()
2013-09-23 0:54 [PATCH 00/20] [SCSI] remove unnecessary pci_set_drvdata() Jingoo Han
` (14 preceding siblings ...)
2013-09-23 1:11 ` [PATCH 15/20] [SCSI] qla4xxx: " Jingoo Han
@ 2013-09-23 1:12 ` Jingoo Han
2013-09-23 1:12 ` [PATCH 17/20] [SCSI] ufs: " Jingoo Han
` (4 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: Jingoo Han @ 2013-09-23 1:12 UTC (permalink / raw)
To: 'James Bottomley'; +Cc: linux-scsi, 'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/scsi/stex.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c
index 325c31c..1aa4bef 100644
--- a/drivers/scsi/stex.c
+++ b/drivers/scsi/stex.c
@@ -1790,8 +1790,6 @@ static void stex_remove(struct pci_dev *pdev)
scsi_remove_host(hba->host);
- pci_set_drvdata(pdev, NULL);
-
stex_hba_stop(hba);
stex_hba_free(hba);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 17/20] [SCSI] ufs: remove unnecessary pci_set_drvdata()
2013-09-23 0:54 [PATCH 00/20] [SCSI] remove unnecessary pci_set_drvdata() Jingoo Han
` (15 preceding siblings ...)
2013-09-23 1:12 ` [PATCH 16/20] [SCSI] stex: " Jingoo Han
@ 2013-09-23 1:12 ` Jingoo Han
2013-09-23 1:13 ` [PATCH 18/20] [SCSI] vmw_pvscsi: " Jingoo Han
` (3 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: Jingoo Han @ 2013-09-23 1:12 UTC (permalink / raw)
To: 'James Bottomley'
Cc: linux-scsi, 'Jingoo Han', 'Vinayak Holikatti',
'Santosh Y'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/scsi/ufs/ufshcd-pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd-pci.c b/drivers/scsi/ufs/ufshcd-pci.c
index a823cf4..8b95312 100644
--- a/drivers/scsi/ufs/ufshcd-pci.c
+++ b/drivers/scsi/ufs/ufshcd-pci.c
@@ -132,7 +132,6 @@ static void ufshcd_pci_remove(struct pci_dev *pdev)
pm_runtime_forbid(&pdev->dev);
pm_runtime_get_noresume(&pdev->dev);
ufshcd_remove(hba);
- pci_set_drvdata(pdev, NULL);
}
/**
--
1.7.10.4
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 18/20] [SCSI] vmw_pvscsi: remove unnecessary pci_set_drvdata()
2013-09-23 0:54 [PATCH 00/20] [SCSI] remove unnecessary pci_set_drvdata() Jingoo Han
` (16 preceding siblings ...)
2013-09-23 1:12 ` [PATCH 17/20] [SCSI] ufs: " Jingoo Han
@ 2013-09-23 1:13 ` Jingoo Han
2013-09-23 1:15 ` [PATCH 19/20] [SCSI] dc395x: " Jingoo Han
` (2 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: Jingoo Han @ 2013-09-23 1:13 UTC (permalink / raw)
To: 'James Bottomley'
Cc: linux-scsi, 'Jingoo Han', 'Arvind Kumar'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/scsi/vmw_pvscsi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c
index 3bfaa66..b9755ec 100644
--- a/drivers/scsi/vmw_pvscsi.c
+++ b/drivers/scsi/vmw_pvscsi.c
@@ -1405,7 +1405,6 @@ out_release_resources:
out_free_host:
scsi_host_put(host);
out_disable_device:
- pci_set_drvdata(pdev, NULL);
pci_disable_device(pdev);
return error;
@@ -1445,7 +1444,6 @@ static void pvscsi_remove(struct pci_dev *pdev)
scsi_host_put(host);
- pci_set_drvdata(pdev, NULL);
pci_disable_device(pdev);
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 19/20] [SCSI] dc395x: remove unnecessary pci_set_drvdata()
2013-09-23 0:54 [PATCH 00/20] [SCSI] remove unnecessary pci_set_drvdata() Jingoo Han
` (17 preceding siblings ...)
2013-09-23 1:13 ` [PATCH 18/20] [SCSI] vmw_pvscsi: " Jingoo Han
@ 2013-09-23 1:15 ` Jingoo Han
2013-09-23 1:16 ` [PATCH 20/20] [SCSI] tmscsim: " Jingoo Han
2013-09-23 18:55 ` [PATCH 00/20] [SCSI] " James Bottomley
20 siblings, 0 replies; 24+ messages in thread
From: Jingoo Han @ 2013-09-23 1:15 UTC (permalink / raw)
To: 'James Bottomley'
Cc: linux-scsi, 'Jingoo Han', 'Oliver Neukum',
'Ali Akcaagac', 'Jamie Lenehan'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/scsi/dc395x.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
index e73445b..61c7cb7 100644
--- a/drivers/scsi/dc395x.c
+++ b/drivers/scsi/dc395x.c
@@ -4859,7 +4859,6 @@ static void dc395x_remove_one(struct pci_dev *dev)
adapter_uninit(acb);
pci_disable_device(dev);
scsi_host_put(scsi_host);
- pci_set_drvdata(dev, NULL);
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 20/20] [SCSI] tmscsim: remove unnecessary pci_set_drvdata()
2013-09-23 0:54 [PATCH 00/20] [SCSI] remove unnecessary pci_set_drvdata() Jingoo Han
` (18 preceding siblings ...)
2013-09-23 1:15 ` [PATCH 19/20] [SCSI] dc395x: " Jingoo Han
@ 2013-09-23 1:16 ` Jingoo Han
2013-09-23 6:29 ` Guennadi Liakhovetski
2013-09-23 18:55 ` [PATCH 00/20] [SCSI] " James Bottomley
20 siblings, 1 reply; 24+ messages in thread
From: Jingoo Han @ 2013-09-23 1:16 UTC (permalink / raw)
To: 'James Bottomley'
Cc: linux-scsi, 'Jingoo Han', 'Kurt Garloff',
'Guennadi Liakhovetski'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/scsi/tmscsim.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/tmscsim.c b/drivers/scsi/tmscsim.c
index 9327f5f..b06a1de 100644
--- a/drivers/scsi/tmscsim.c
+++ b/drivers/scsi/tmscsim.c
@@ -2553,7 +2553,6 @@ static void dc390_remove_one(struct pci_dev *dev)
pci_disable_device(dev);
scsi_host_put(scsi_host);
- pci_set_drvdata(dev, NULL);
}
static struct pci_device_id tmscsim_pci_tbl[] = {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH 20/20] [SCSI] tmscsim: remove unnecessary pci_set_drvdata()
2013-09-23 1:16 ` [PATCH 20/20] [SCSI] tmscsim: " Jingoo Han
@ 2013-09-23 6:29 ` Guennadi Liakhovetski
0 siblings, 0 replies; 24+ messages in thread
From: Guennadi Liakhovetski @ 2013-09-23 6:29 UTC (permalink / raw)
To: Jingoo Han; +Cc: 'James Bottomley', linux-scsi, 'Kurt Garloff'
On Mon, 23 Sep 2013, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Thanks
Guennadi
> ---
> drivers/scsi/tmscsim.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/tmscsim.c b/drivers/scsi/tmscsim.c
> index 9327f5f..b06a1de 100644
> --- a/drivers/scsi/tmscsim.c
> +++ b/drivers/scsi/tmscsim.c
> @@ -2553,7 +2553,6 @@ static void dc390_remove_one(struct pci_dev *dev)
>
> pci_disable_device(dev);
> scsi_host_put(scsi_host);
> - pci_set_drvdata(dev, NULL);
> }
>
> static struct pci_device_id tmscsim_pci_tbl[] = {
> --
> 1.7.10.4
>
>
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 00/20] [SCSI] remove unnecessary pci_set_drvdata()
2013-09-23 0:54 [PATCH 00/20] [SCSI] remove unnecessary pci_set_drvdata() Jingoo Han
` (19 preceding siblings ...)
2013-09-23 1:16 ` [PATCH 20/20] [SCSI] tmscsim: " Jingoo Han
@ 2013-09-23 18:55 ` James Bottomley
2013-09-24 1:19 ` Jingoo Han
20 siblings, 1 reply; 24+ messages in thread
From: James Bottomley @ 2013-09-23 18:55 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-scsi, trivial
On Mon, 2013-09-23 at 09:54 +0900, Jingoo Han wrote:
> Since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound),
> the driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
Look, these are particularly pointless patches. The null setting is
only on teardown; the fact that we set something to NULL that should
already be null doesn't matter at all the extra cycles simply won't be
noticed. Please roll them into a single patch and send them to Jiří
Kosina and the trivial tree (cc'd) he'll take care of checking and
applying them (assuming they meet his criteria for worth bothering
with).
Thanks,
James
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 00/20] [SCSI] remove unnecessary pci_set_drvdata()
2013-09-23 18:55 ` [PATCH 00/20] [SCSI] " James Bottomley
@ 2013-09-24 1:19 ` Jingoo Han
0 siblings, 0 replies; 24+ messages in thread
From: Jingoo Han @ 2013-09-24 1:19 UTC (permalink / raw)
To: 'James Bottomley'; +Cc: linux-scsi, trivial, 'Jingoo Han'
On Tuesday, September 24, 2013 3:55 AM, James Bottomley wrote:
> On Mon, 2013-09-23 at 09:54 +0900, Jingoo Han wrote:
> > Since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> > (device-core: Ensure drvdata = NULL when no driver is bound),
> > the driver core clears the driver data to NULL after device_release
> > or on probe failure. Thus, it is not needed to manually clear the
> > device driver data to NULL.
>
> Look, these are particularly pointless patches. The null setting is
> only on teardown; the fact that we set something to NULL that should
> already be null doesn't matter at all the extra cycles simply won't be
> noticed. Please roll them into a single patch and send them to Jiří
> Kosina and the trivial tree (cc'd) he'll take care of checking and
> applying them (assuming they meet his criteria for worth bothering
> with).
>
OK, I see.
I squashed all 20 patches into a single patch, and sent the single patch
to Jiri Kosina and the trivial tree, as you mentioned.
Thank you for your guidance.
Best regards,
Jingoo Han
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 24+ messages in thread
end of thread, other threads:[~2013-09-24 1:19 UTC | newest]
Thread overview: 24+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-23 0:54 [PATCH 00/20] [SCSI] remove unnecessary pci_set_drvdata() Jingoo Han
2013-09-23 0:55 ` [PATCH 01/20] [SCSI] lpfc 8.3.42: " Jingoo Han
2013-09-23 0:57 ` [PATCH 02/20] [SCSI] arcmsr: " Jingoo Han
2013-09-23 0:58 ` [PATCH 03/20] [SCSI] atp870u: " Jingoo Han
2013-09-23 0:59 ` [PATCH 04/20] [SCSI] bfa: " Jingoo Han
2013-09-23 1:00 ` [PATCH 05/20] [SCSI] csiostor: " Jingoo Han
2013-09-23 1:01 ` [PATCH 06/20] [SCSI] fnic: " Jingoo Han
2013-09-23 1:02 ` [PATCH 07/20] [SCSI] gdth: " Jingoo Han
2013-09-23 1:03 ` [PATCH 08/20] [SCSI] hpsa: " Jingoo Han
2013-09-23 1:03 ` [PATCH 09/20] [SCSI] megaraid: " Jingoo Han
2013-09-23 1:05 ` [PATCH 10/20] [SCSI] mvumi: " Jingoo Han
2013-09-23 1:06 ` [PATCH 11/20] [SCSI] mvsas: " Jingoo Han
2013-09-23 1:08 ` [PATCH 12/20] [SCSI] pm80xx: " Jingoo Han
2013-09-23 1:09 ` [PATCH 13/20] [SCSI] pmcraid: " Jingoo Han
2013-09-23 1:10 ` [PATCH 14/20] [SCSI] qla2xxx: " Jingoo Han
2013-09-23 1:11 ` [PATCH 15/20] [SCSI] qla4xxx: " Jingoo Han
2013-09-23 1:12 ` [PATCH 16/20] [SCSI] stex: " Jingoo Han
2013-09-23 1:12 ` [PATCH 17/20] [SCSI] ufs: " Jingoo Han
2013-09-23 1:13 ` [PATCH 18/20] [SCSI] vmw_pvscsi: " Jingoo Han
2013-09-23 1:15 ` [PATCH 19/20] [SCSI] dc395x: " Jingoo Han
2013-09-23 1:16 ` [PATCH 20/20] [SCSI] tmscsim: " Jingoo Han
2013-09-23 6:29 ` Guennadi Liakhovetski
2013-09-23 18:55 ` [PATCH 00/20] [SCSI] " James Bottomley
2013-09-24 1:19 ` Jingoo Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).