public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Seungwon Jeon <tgih.jun@samsung.com>
To: linux-scsi@vger.kernel.org
Cc: 'Vinayak Holikatti' <vinholikatti@gmail.com>,
	'Santosh Y' <santoshsy@gmail.com>,
	"'James E.J. Bottomley'" <JBottomley@parallels.com>
Subject: [PATCH v3 3/6] scsi: ufs: fix interrupt status clears
Date: Mon, 06 May 2013 14:37:27 +0900	[thread overview]
Message-ID: <001301ce4a1b$cb5bda50$62138ef0$%jun@samsung.com> (raw)
In-Reply-To: <000b01ce48a3$ad7072e0$085158a0$%jun@samsung.com>

There is no need to check the version to clear
the interrupt status. And the order is changed
prior to actual handling.

Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
---
 drivers/scsi/ufs/ufshcd.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index feaf221..e04c74e 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -1582,11 +1582,8 @@ static irqreturn_t ufshcd_intr(int irq, void *__hba)
 	intr_status = ufshcd_readl(hba, REG_INTERRUPT_STATUS);
 
 	if (intr_status) {
+		ufshcd_writel(hba, intr_status, REG_INTERRUPT_STATUS);
 		ufshcd_sl_intr(hba, intr_status);
-
-		/* If UFSHCI 1.0 then clear interrupt status register */
-		if (hba->ufs_version == UFSHCI_VERSION_10)
-			ufshcd_writel(hba, intr_status, REG_INTERRUPT_STATUS);
 		retval = IRQ_HANDLED;
 	}
 	spin_unlock(hba->host->host_lock);
-- 
1.7.0.4



  parent reply	other threads:[~2013-05-06  5:37 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-24 14:14 [PATCH 1/1] scsi: ufs: Add support for sending NOP OUT UPIU Sujit Reddy Thumma
2013-04-24 16:06 ` [PATCH 1/5] scsi: ufs: move the ufshcd_hba_stop to ufshcd.c Seungwon Jeon
2013-04-30 11:17   ` Subhash Jadavani
2013-05-01  7:46     ` merez
2013-05-02  8:11   ` Santosh Y
2013-05-02 13:37     ` Seungwon Jeon
2013-05-02 18:49     ` merez
2013-05-04  8:45   ` [PATCH v2 1/7] " Seungwon Jeon
2013-05-05 11:22     ` merez
2013-05-06  3:05       ` Seungwon Jeon
2013-05-06  5:37     ` [PATCH v3 1/6] scsi: ufs: wrap the i/o access operations Seungwon Jeon
2013-05-06 10:37       ` merez
2013-05-06 19:30       ` Santosh Y
2013-05-07  3:52         ` Seungwon Jeon
2013-05-06  5:37     ` [PATCH v3 2/6] scsi: ufs: amend interrupt configuration Seungwon Jeon
2013-05-06 10:39       ` merez
2013-05-06  5:37     ` Seungwon Jeon [this message]
2013-05-06 10:49       ` [PATCH v3 3/6] scsi: ufs: fix interrupt status clears merez
2013-05-06  5:37     ` [PATCH v3 4/6] scsi: ufs: rework link start-up process Seungwon Jeon
2013-05-06  9:47       ` Sujit Reddy Thumma
2013-05-06 10:36         ` merez
2013-05-06 11:21         ` Seungwon Jeon
2013-05-06 18:15           ` merez
2013-05-06  5:37     ` [PATCH v3 5/6] scsi: ufs: add dme configuration primitives Seungwon Jeon
2013-05-06 19:43       ` Santosh Y
2013-05-06  5:39     ` [PATCH v3 6/6] scsi: ufs: add dme control primitives Seungwon Jeon
2013-05-06 19:51       ` Santosh Y
2013-05-07  3:45         ` Seungwon Jeon
2013-05-08  8:41     ` [PATCH v4 1/6] scsi: ufs: wrap the i/o access operations Seungwon Jeon
2013-05-08 11:58       ` merez
2013-05-08 15:18       ` Santosh Y
2013-05-09  1:59         ` Seungwon Jeon
2013-05-09  3:27           ` Santosh Y
2013-05-09  6:39             ` Seungwon Jeon
2013-05-09  6:52               ` Santosh Y
2013-05-09 14:21                 ` James Bottomley
2013-05-10  1:52                   ` Seungwon Jeon
2013-05-08  8:41     ` [PATCH v4 2/6] scsi: ufs: amend interrupt configuration Seungwon Jeon
2013-05-08 15:19       ` Santosh Y
2013-05-08  8:41     ` [PATCH v4 3/6] scsi: ufs: fix interrupt status clears Seungwon Jeon
2013-05-08 15:19       ` Santosh Y
2013-05-08  8:42     ` [PATCH v4 4/6] scsi: ufs: rework link start-up process Seungwon Jeon
2013-05-08 15:20       ` Santosh Y
2013-05-08  8:42     ` [PATCH v4 5/6] scsi: ufs: add dme configuration primitives Seungwon Jeon
2013-05-09  6:53       ` Santosh Y
2013-05-08  8:43     ` [PATCH v4 6/6] scsi: ufs: add dme control primitives Seungwon Jeon
2013-05-09  6:53       ` Santosh Y
2013-05-10 10:42     ` [PATCH] scsi: ufs: use devres functions for ufshcd Seungwon Jeon
2013-05-10 11:00       ` Seungwon Jeon
2013-05-10 11:05       ` [PATCH resend] " Seungwon Jeon
2013-05-02  7:27 ` [PATCH 1/1] scsi: ufs: Add support for sending NOP OUT UPIU Santosh Y
2013-05-02 11:31   ` Sujit Reddy Thumma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='001301ce4a1b$cb5bda50$62138ef0$%jun@samsung.com' \
    --to=tgih.jun@samsung.com \
    --cc=JBottomley@parallels.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=santoshsy@gmail.com \
    --cc=vinholikatti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox