RE: Request for review of Linux iSCSI driver version 4.0.0.2

["Surekha.PC" <surekhap@cisco.com>]

>> 10.  - the procfs code is a mess.  Please move it over to
>>         proper per-device / per-host sysfs attributes as procfs
>>         support in HBA drivers is deprecated.

>please don't add an attribute group, just use the shost_attrs field in
the host template.
 
Can you please let me know why we should not use attribute group? Isn't
it recommended for the driver writers to use it?

The main reason for using this was to have all iSCSI specific files in
one place so that its' easier for the user to find them. There are many
iSCSI attributes which will need to be changed/read, so we preferred to
put in one place.

>iscsi_show_device() doesn't look like a good idea,what about adding an
iscsi pseudo 
device as parent to identify the device as iscsi in sysfs?

iscsi_show_device() creates sysfs file "device_type" which is checked
while parsing "udev.config" for iSCSI device activation. Since device
attributes like vendor, model etc reside in this directory, isn't it ok
to have it here?

If not, would like to know what field we need to use, for adding iscsi
peusdo device as parent, I doubt this can be done with shost_attrs and
sdev_attrs of host template.   

>This whole find_keyword business is not good.  sysfs files are supposed
to have a single >value.  We should probably do some brainstorming on
the right API for this..

Our driver has lot of user space attributes. Making each attribute as a
separate file will endup with lots of files. So we want to have all
target specific attributes together in one file and lun specific
attributes in another file for convinience. find_keyword() will help
search for these keys from the cmdline specified.

Pls let me know your suggestions.

Thanks,
surekha