Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: "Kiwoong Kim" <kwmad.kim@samsung.com>
To: "'Bart Van Assche'" <bvanassche@acm.org>,
	"'Bean Huo'" <beanhuo@iokpp.de>, <linux-scsi@vger.kernel.org>
Subject: RE: [PATCH v5 2/2] ufs: mcq: poll OCS after sq cleanup for device management commands
Date: Thu, 5 Nov 2026 09:35:22 +0900	[thread overview]
Message-ID: <002d01dd6cbd$8aca10a0$a05e31e0$@samsung.com> (raw)
In-Reply-To: <d6b1da22-2a18-4966-83df-86cb9031fdde@acm.org>

> > READ_ONCE() is enough to read OCS, but the lock also is to make sure
> > ufshcd_compl_one_cqe() has finished?  the window is very small, and
> > the lock only costs something on this error handling path.
> 
> I overlooked that lrbp->utr_descriptor_ptr->header.ocs is what is being
> polled instead of the OCS field in the CQE. Kiwoong, can you please
> restore the code that obtains hwq->cq_lock?
> 
> Thanks,
> 
> Bart.

Got it.

Thanks.


  reply	other threads:[~2026-11-05  0:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20261104094922epcas2p275e9b663a40b1a6f86f208f11e21ae64@epcas2p2.samsung.com>
2026-11-04  9:49 ` [PATCH v5 0/2] ufs: fix the abort path of device management commands in MCQ mode Kiwoong Kim
2026-11-04  9:49   ` [PATCH v5 1/2] ufs: core: skip ABORT TASK for device management commands Kiwoong Kim
2026-11-04  9:49   ` [PATCH v5 2/2] ufs: mcq: poll OCS after sq cleanup " Kiwoong Kim
2026-11-04 10:08     ` sashiko-bot
2026-11-04 20:17     ` Bean Huo
2026-11-04 21:34       ` Bart Van Assche
2026-11-05  0:35         ` Kiwoong Kim [this message]
2026-11-04 20:19     ` Bean Huo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002d01dd6cbd$8aca10a0$a05e31e0$@samsung.com' \
    --to=kwmad.kim@samsung.com \
    --cc=beanhuo@iokpp.de \
    --cc=bvanassche@acm.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox