From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jingoo Han Subject: Re: [PATCH 3/8] [SCSI] dc395x: use NULL instead of 0 Date: Wed, 07 Aug 2013 16:45:58 +0900 Message-ID: <004901ce9342$27e2e970$77a8bc50$@samsung.com> References: <001301ce9321$f2157760$d6406620$@samsung.com> <1375858203.1359.1.camel@linux-fkkt.site> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout3.samsung.com ([203.254.224.33]:14555 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932188Ab3HGHqA (ORCPT ); Wed, 7 Aug 2013 03:46:00 -0400 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MR500I1CHJU51E0@mailout3.samsung.com> for linux-scsi@vger.kernel.org; Wed, 07 Aug 2013 16:45:59 +0900 (KST) In-reply-to: <1375858203.1359.1.camel@linux-fkkt.site> Content-language: ko Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: 'Oliver Neukum' Cc: 'James Bottomley' , 'Ali Akcaagac' , 'Jamie Lenehan' , dc395x@twibble.org, 'James Bottomley' , linux-scsi@vger.kernel.org, Jingoo Han On Wednesday, August 07, 2013 3:50 PM, Oliver Neukum wrote: > On Wed, 2013-08-07 at 12:55 +0900, Jingoo Han wrote: > > > @@ -4183,15 +4183,17 @@ static void check_eeprom(struct NvRamType *eeprom, unsigned long io_port) > > */ > > dprintkl(KERN_WARNING, > > "EEProm checksum error: using default values and options.\n"); > > - eeprom->sub_vendor_id[0] = (u8)PCI_VENDOR_ID_TEKRAM; > > + eeprom->sub_vendor_id[0] = (u8)(PCI_VENDOR_ID_TEKRAM & 0xff); > > Hi, > > if you are fixing these issues please use the proper macros for > conversion of endianness. Then, do you mean the following? :) - prom->sub_vendor_id[0] = (u8)PCI_VENDOR_ID_TEKRAM; + eprom->sub_vendor_id[0] = (u8)(PCI_VENDOR_ID_TEKRAM & le16_to_cpu(0xff)); Best regards, Jingoo Han