* Re: [PATCH -next] scsi: ufs: Fix 'unmet direct dependencies' config warning
2020-07-21 17:20 ` [PATCH -next] scsi: ufs: Fix 'unmet direct dependencies' config warning Alim Akhtar
@ 2020-07-21 17:57 ` Randy Dunlap
2020-08-05 1:32 ` Alim Akhtar
2020-07-22 4:28 ` Martin K. Petersen
2020-09-15 20:16 ` Martin K. Petersen
2 siblings, 1 reply; 7+ messages in thread
From: Randy Dunlap @ 2020-07-21 17:57 UTC (permalink / raw)
To: Alim Akhtar, martin.petersen; +Cc: avri.altman, linux-scsi, sfr
On 7/21/20 10:20 AM, Alim Akhtar wrote:
> With !CONFIG_OF and SCSI_UFS_EXYNOS selected, the below
> warning is given:
>
> WARNING: unmet direct dependencies detected for PHY_SAMSUNG_UFS
> Depends on [n]: OF [=n] && (ARCH_EXYNOS || COMPILE_TEST [=y])
> Selected by [y]:
> - SCSI_UFS_EXYNOS [=y] && SCSI_LOWLEVEL [=y] && SCSI [=y] && SCSI_UFSHCD_PLATFORM [=y] && (ARCH_EXYNOS || COMPILE_TEST [=y])
>
> Fix it by removing PHY_SAMSUNG_UFS dependency.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
Looks good. Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> drivers/scsi/ufs/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig
> index 46a4542f37eb..590768758fc6 100644
> --- a/drivers/scsi/ufs/Kconfig
> +++ b/drivers/scsi/ufs/Kconfig
> @@ -164,7 +164,6 @@ config SCSI_UFS_BSG
> config SCSI_UFS_EXYNOS
> tristate "EXYNOS specific hooks to UFS controller platform driver"
> depends on SCSI_UFSHCD_PLATFORM && (ARCH_EXYNOS || COMPILE_TEST)
> - select PHY_SAMSUNG_UFS
> help
> This selects the EXYNOS specific additions to UFSHCD platform driver.
> UFS host on EXYNOS includes HCI and UNIPRO layer, and associates with
>
> base-commit: ab8be66e724ecf4bffb2895c9c91bbd44fa687c7
>
--
~Randy
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH -next] scsi: ufs: Fix 'unmet direct dependencies' config warning
2020-07-21 17:57 ` Randy Dunlap
@ 2020-08-05 1:32 ` Alim Akhtar
2020-08-05 1:37 ` Martin K. Petersen
0 siblings, 1 reply; 7+ messages in thread
From: Alim Akhtar @ 2020-08-05 1:32 UTC (permalink / raw)
To: 'Randy Dunlap', martin.petersen; +Cc: avri.altman, linux-scsi, sfr
Hi Martin,
> On 7/21/20 10:20 AM, Alim Akhtar wrote:
> > With !CONFIG_OF and SCSI_UFS_EXYNOS selected, the below warning is
> > given:
> >
> > WARNING: unmet direct dependencies detected for PHY_SAMSUNG_UFS
> > Depends on [n]: OF [=n] && (ARCH_EXYNOS || COMPILE_TEST [=y])
> > Selected by [y]:
> > - SCSI_UFS_EXYNOS [=y] && SCSI_LOWLEVEL [=y] && SCSI [=y] &&
> > SCSI_UFSHCD_PLATFORM [=y] && (ARCH_EXYNOS || COMPILE_TEST [=y])
> >
> > Fix it by removing PHY_SAMSUNG_UFS dependency.
> >
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>
> Looks good. Thanks.
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>
I don’t see this patch in your tree, let me know if I need to -resend this.
Thanks!
> > ---
> > drivers/scsi/ufs/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig index
> > 46a4542f37eb..590768758fc6 100644
> > --- a/drivers/scsi/ufs/Kconfig
> > +++ b/drivers/scsi/ufs/Kconfig
> > @@ -164,7 +164,6 @@ config SCSI_UFS_BSG config SCSI_UFS_EXYNOS
> > tristate "EXYNOS specific hooks to UFS controller platform driver"
> > depends on SCSI_UFSHCD_PLATFORM && (ARCH_EXYNOS ||
> COMPILE_TEST)
> > - select PHY_SAMSUNG_UFS
> > help
> > This selects the EXYNOS specific additions to UFSHCD platform driver.
> > UFS host on EXYNOS includes HCI and UNIPRO layer, and associates
> > with
> >
> > base-commit: ab8be66e724ecf4bffb2895c9c91bbd44fa687c7
> >
>
>
> --
> ~Randy
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -next] scsi: ufs: Fix 'unmet direct dependencies' config warning
2020-08-05 1:32 ` Alim Akhtar
@ 2020-08-05 1:37 ` Martin K. Petersen
2020-08-05 1:48 ` Alim Akhtar
0 siblings, 1 reply; 7+ messages in thread
From: Martin K. Petersen @ 2020-08-05 1:37 UTC (permalink / raw)
To: Alim Akhtar
Cc: 'Randy Dunlap', martin.petersen, avri.altman, linux-scsi,
sfr
Alim,
> I don’t see this patch in your tree, let me know if I need to -resend
> this.
I postponed the Exynos update to 5.10 since there were a few zeroday
warnings and it looked like the 5.8 release was imminent.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH -next] scsi: ufs: Fix 'unmet direct dependencies' config warning
2020-08-05 1:37 ` Martin K. Petersen
@ 2020-08-05 1:48 ` Alim Akhtar
0 siblings, 0 replies; 7+ messages in thread
From: Alim Akhtar @ 2020-08-05 1:48 UTC (permalink / raw)
To: 'Martin K. Petersen'
Cc: 'Randy Dunlap', avri.altman, linux-scsi, sfr
> -----Original Message-----
> From: Martin K. Petersen <martin.petersen@oracle.com>
> Sent: 05 August 2020 07:07
> To: Alim Akhtar <alim.akhtar@samsung.com>
> Cc: 'Randy Dunlap' <rdunlap@infradead.org>; martin.petersen@oracle.com;
> avri.altman@wdc.com; linux-scsi@vger.kernel.org; sfr@canb.auug.org.au
> Subject: Re: [PATCH -next] scsi: ufs: Fix 'unmet direct dependencies' config
> warning
>
>
> Alim,
>
> > I don’t see this patch in your tree, let me know if I need to -resend
> > this.
>
> I postponed the Exynos update to 5.10 since there were a few zeroday warnings
> and it looked like the 5.8 release was imminent.
>
I suppose all fixes where sent on time for ufs-exynos driver. Anyway let me know in case
I need to re-send any patches.
The $SUBJECT patch is needed to fix a build warning.
Thank you!
> --
> Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -next] scsi: ufs: Fix 'unmet direct dependencies' config warning
2020-07-21 17:20 ` [PATCH -next] scsi: ufs: Fix 'unmet direct dependencies' config warning Alim Akhtar
2020-07-21 17:57 ` Randy Dunlap
@ 2020-07-22 4:28 ` Martin K. Petersen
2020-09-15 20:16 ` Martin K. Petersen
2 siblings, 0 replies; 7+ messages in thread
From: Martin K. Petersen @ 2020-07-22 4:28 UTC (permalink / raw)
To: Alim Akhtar; +Cc: Martin K . Petersen, rdunlap, linux-scsi, avri.altman, sfr
On Tue, 21 Jul 2020 22:50:21 +0530, Alim Akhtar wrote:
> With !CONFIG_OF and SCSI_UFS_EXYNOS selected, the below
> warning is given:
>
> WARNING: unmet direct dependencies detected for PHY_SAMSUNG_UFS
> Depends on [n]: OF [=n] && (ARCH_EXYNOS || COMPILE_TEST [=y])
> Selected by [y]:
> - SCSI_UFS_EXYNOS [=y] && SCSI_LOWLEVEL [=y] && SCSI [=y] && SCSI_UFSHCD_PLATFORM [=y] && (ARCH_EXYNOS || COMPILE_TEST [=y])
>
> [...]
Applied to 5.9/scsi-queue, thanks!
[1/1] scsi: ufs: Fix 'unmet direct dependencies' config warning
https://git.kernel.org/mkp/scsi/c/7f1c8efd28f7
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH -next] scsi: ufs: Fix 'unmet direct dependencies' config warning
2020-07-21 17:20 ` [PATCH -next] scsi: ufs: Fix 'unmet direct dependencies' config warning Alim Akhtar
2020-07-21 17:57 ` Randy Dunlap
2020-07-22 4:28 ` Martin K. Petersen
@ 2020-09-15 20:16 ` Martin K. Petersen
2 siblings, 0 replies; 7+ messages in thread
From: Martin K. Petersen @ 2020-09-15 20:16 UTC (permalink / raw)
To: Alim Akhtar; +Cc: Martin K . Petersen, rdunlap, avri.altman, sfr, linux-scsi
On Tue, 21 Jul 2020 22:50:21 +0530, Alim Akhtar wrote:
> With !CONFIG_OF and SCSI_UFS_EXYNOS selected, the below
> warning is given:
>
> WARNING: unmet direct dependencies detected for PHY_SAMSUNG_UFS
> Depends on [n]: OF [=n] && (ARCH_EXYNOS || COMPILE_TEST [=y])
> Selected by [y]:
> - SCSI_UFS_EXYNOS [=y] && SCSI_LOWLEVEL [=y] && SCSI [=y] && SCSI_UFSHCD_PLATFORM [=y] && (ARCH_EXYNOS || COMPILE_TEST [=y])
>
> [...]
Applied to 5.10/scsi-queue, thanks!
[1/1] scsi: ufs: Fix 'unmet direct dependencies' config warning
https://git.kernel.org/mkp/scsi/c/09fd5f0ddf32
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread