From: "Tony Battersby" <tonyb@cybernetics.com>
To: 'Tom Coughlan' <coughlan@redhat.com>, linux-scsi@vger.kernel.org
Subject: RE: [PATCH] fix disk geometry calculation for large disks
Date: Mon, 2 May 2005 13:18:10 -0400 [thread overview]
Message-ID: <006901c54f3a$eaaf1f50$e0019d89@cybernetics.com> (raw)
In-Reply-To: <1115052512.11434.2738.camel@bianchi.boston.redhat.com>
> Testing with multi-terabyte disks shows that HDIO_GETGEO sometimes
> returns heads=0. This causes parted to die with a Floating Point
> Exception, among other possible effects.
>
> The problem occurs because several routines in scsicam_bios_param cast
> sector_t capacity to unsigned long.
>
> The attached patch avoids this, by checking first to see if
> the capacity
> exceeds the maximum allowed values for cylinder/sector/head
> (65535*63*255). If so, just return those values right away.
I brought up this issue a few months ago
(http://marc.theaimsgroup.com/?t=110383771000001&r=1&w=2), but no one
replied. There are actually many other drivers with custom bios_param()
routines that should be reviewed as well.
Anthony J. Battersby
Cybernetics
prev parent reply other threads:[~2005-05-02 17:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-02 16:48 [PATCH] fix disk geometry calculation for large disks Tom Coughlan
2005-05-02 17:18 ` Tony Battersby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='006901c54f3a$eaaf1f50$e0019d89@cybernetics.com' \
--to=tonyb@cybernetics.com \
--cc=coughlan@redhat.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox