From: "lindar_liu" <lindar_liu@usish.com>
To: 'James Bottomley' <James.Bottomley@HansenPartnership.com>,
'linux-scsi' <linux-scsi@vger.kernel.org>
Cc: 'Lukasz Dorau' <lukasz.dorau@intel.com>,
'Maciej Patelczyk' <maciej.patelczyk@intel.com>,
'Dave Jiang' <dave.jiang@intel.com>,
xjtuwjp@gmail.com, 'Xiangliang Yu' <yuxiangl@marvell.com>
Subject: RE: [PATCH] sas: unify the pointlessly separated enums sas_dev_type and sas_device_type
Date: Wed, 8 May 2013 09:50:12 +0800 [thread overview]
Message-ID: <007301ce4b8e$63b441c0$2b1cc540$@com> (raw)
In-Reply-To: <1367963046.4108.25.camel@dabdike>
Thanks for fix.
Lindar.
-----Original Message-----
From: James Bottomley [mailto:James.Bottomley@HansenPartnership.com]
Sent: Wednesday, May 08, 2013 5:44 AM
To: linux-scsi
Cc: Lukasz Dorau; Maciej Patelczyk; Dave Jiang; xjtuwjp@gmail.com;
lindar_liu@usish.com; Xiangliang Yu
Subject: [PATCH] sas: unify the pointlessly separated enums sas_dev_type and
sas_device_type
These enums have been separate since the dawn of SAS, mainly because the
latter is a procotol only enum and the former includes additional state for
libsas. The dichotomy causes endless confusion about which one you should
use where and leads to pointless warnings like this:
drivers/scsi/mvsas/mv_sas.c: In function 'mvs_update_phyinfo':
drivers/scsi/mvsas/mv_sas.c:1162:34: warning: comparison between 'enum
sas_device_type' and 'enum sas_dev_type' [-Wenum-compare]
Fix by eliminating one of them. The one kept is effectively the sas.h one,
but call it sas_device_type and make sure the enums are all properly
namespaced with the SAS_ prefix.
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
---
prev parent reply other threads:[~2013-05-08 2:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 21:44 [PATCH] sas: unify the pointlessly separated enums sas_dev_type and sas_device_type James Bottomley
2013-05-08 1:50 ` lindar_liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='007301ce4b8e$63b441c0$2b1cc540$@com' \
--to=lindar_liu@usish.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dave.jiang@intel.com \
--cc=linux-scsi@vger.kernel.org \
--cc=lukasz.dorau@intel.com \
--cc=maciej.patelczyk@intel.com \
--cc=xjtuwjp@gmail.com \
--cc=yuxiangl@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox