public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: "Tony Battersby" <tonyb@cybernetics.com>
To: 'Matthew Wilcox' <matthew@wil.cx>,
	"'Stephens, Larry'" <larry.stephens@lsil.com>
Cc: "'Linux-Scsi@Vger. Kernel. Org (E-mail)'" <linux-scsi@vger.kernel.org>
Subject: RE: Sym53c8xx_2 Odd Byte Data Transfer patches
Date: Tue, 14 Jun 2005 18:00:38 -0400	[thread overview]
Message-ID: <009301c5712c$80200910$e0019d89@cybernetics.com> (raw)
In-Reply-To: <20050614205041.GB11655@parcelfarce.linux.theplanet.co.uk>

> While this patch does seem to solve the problem of transferring an odd
> number of bytes to the device, I recently received a bug report saying
> that we don't accept an odd number of bytes transferred from a device.
> It seems to me that it's going to require modifying the scsi
> scripts in
> order to do this.  Do you agree?  Have you looked into
> transfers in the
> opposite direction as part of this work?

If a target sends an odd number of bytes during a wide DATA IN phase,
then it should send an IGNORE WIDE RESIDUE message immediately after
exiting the data phase to inform the initiator.  The sym53c8xx_2 driver
in the 2.4 kernel series handles this correctly except on a REQUEST
SENSE command issued for autosense (previously sym53c8xx_2 would reject
an IWR message for autosense; I submitted a patch a good while ago to
make it ignore IWR in this case instead of rejecting it).  Not
accounting for IWR on autosense is not a big deal though, so I consider
sym53c8xx_2 in 2.4 kernels to handle odd-length DATA IN phases
acceptably.  I haven't tested the 2.6 kernels.

Anthony J. Battersby
Cybernetics


  reply	other threads:[~2005-06-14 22:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-09 12:16 Sym53c8xx_2 Odd Byte Data Transfer patches Stephens, Larry
2005-05-09 14:34 ` Tony Battersby
2005-06-14 20:50 ` Matthew Wilcox
2005-06-14 22:00   ` Tony Battersby [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-06-15 12:16 Stephens, Larry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='009301c5712c$80200910$e0019d89@cybernetics.com' \
    --to=tonyb@cybernetics.com \
    --cc=larry.stephens@lsil.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=matthew@wil.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox