RE: [PATCH 11/16] pm8001: clean up unnecessary MSI/MSI-X capability find

["lindar_liu" <lindar_liu@usish.com>]

On 08/08/2013 9:10 PM, Yijing Wang wrote: 
> PCI core will initialize device MSI/MSI-X capability in
> pci_msi_init_pci_dev(). So device driver should use pci_dev-
> >msi_cap/msix_cap to determine whether the device support MSI/MSI-X
> instead of using pci_find_capability(pci_dev, PCI_CAP_ID_MSI/MSIX).
> Access to PCIe device config space again will consume more time.
>
It's fine.
You can add my Acked-by.

Thanks,
Lindar
> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
> Cc: xjtuwjp@gmail.com
> Cc: lindar_liu@usish.com
> Cc: "James E.J. Bottomley" <JBottomley@parallels.com>
> Cc: linux-scsi@vger.kernel.org
> ---
>  drivers/scsi/pm8001/pm8001_init.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/scsi/pm8001/pm8001_init.c
> b/drivers/scsi/pm8001/pm8001_init.c
> index 3861aa1..1ee61e8 100644
> --- a/drivers/scsi/pm8001/pm8001_init.c
> +++ b/drivers/scsi/pm8001/pm8001_init.c
> @@ -734,7 +734,7 @@ static u32 pm8001_request_irq(struct
> pm8001_hba_info *pm8001_ha)
>  	pdev = pm8001_ha->pdev;
> 
>  #ifdef PM8001_USE_MSIX
> -	if (pci_find_capability(pdev, PCI_CAP_ID_MSIX))
> +	if (pdev->msix_cap)
>  		return pm8001_setup_msix(pm8001_ha);
>  	else {
>  		PM8001_INIT_DBG(pm8001_ha,
> --
> 1.7.1