* [PATCH 11/16] pm8001: clean up unnecessary MSI/MSI-X capability find
@ 2013-08-08 13:10 Yijing Wang
2013-08-09 2:57 ` lindar_liu
0 siblings, 1 reply; 3+ messages in thread
From: Yijing Wang @ 2013-08-08 13:10 UTC (permalink / raw)
To: James E.J. Bottomley
Cc: Hanjun Guo, jiang.liu, Yijing Wang, xjtuwjp, lindar_liu,
linux-scsi
PCI core will initialize device MSI/MSI-X capability in
pci_msi_init_pci_dev(). So device driver should use
pci_dev->msi_cap/msix_cap to determine whether the device
support MSI/MSI-X instead of using
pci_find_capability(pci_dev, PCI_CAP_ID_MSI/MSIX).
Access to PCIe device config space again will consume more time.
Signed-off-by: Yijing Wang <wangyijing@huawei.com>
Cc: xjtuwjp@gmail.com
Cc: lindar_liu@usish.com
Cc: "James E.J. Bottomley" <JBottomley@parallels.com>
Cc: linux-scsi@vger.kernel.org
---
drivers/scsi/pm8001/pm8001_init.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c
index 3861aa1..1ee61e8 100644
--- a/drivers/scsi/pm8001/pm8001_init.c
+++ b/drivers/scsi/pm8001/pm8001_init.c
@@ -734,7 +734,7 @@ static u32 pm8001_request_irq(struct pm8001_hba_info *pm8001_ha)
pdev = pm8001_ha->pdev;
#ifdef PM8001_USE_MSIX
- if (pci_find_capability(pdev, PCI_CAP_ID_MSIX))
+ if (pdev->msix_cap)
return pm8001_setup_msix(pm8001_ha);
else {
PM8001_INIT_DBG(pm8001_ha,
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH 11/16] pm8001: clean up unnecessary MSI/MSI-X capability find
2013-08-08 13:10 [PATCH 11/16] pm8001: clean up unnecessary MSI/MSI-X capability find Yijing Wang
@ 2013-08-09 2:57 ` lindar_liu
2013-08-09 7:30 ` Yijing Wang
0 siblings, 1 reply; 3+ messages in thread
From: lindar_liu @ 2013-08-09 2:57 UTC (permalink / raw)
To: 'Yijing Wang', 'James E.J. Bottomley'
Cc: 'Hanjun Guo', jiang.liu, xjtuwjp, linux-scsi
On 08/08/2013 9:10 PM, Yijing Wang wrote:
> PCI core will initialize device MSI/MSI-X capability in
> pci_msi_init_pci_dev(). So device driver should use pci_dev-
> >msi_cap/msix_cap to determine whether the device support MSI/MSI-X
> instead of using pci_find_capability(pci_dev, PCI_CAP_ID_MSI/MSIX).
> Access to PCIe device config space again will consume more time.
>
It's fine.
You can add my Acked-by.
Thanks,
Lindar
> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
> Cc: xjtuwjp@gmail.com
> Cc: lindar_liu@usish.com
> Cc: "James E.J. Bottomley" <JBottomley@parallels.com>
> Cc: linux-scsi@vger.kernel.org
> ---
> drivers/scsi/pm8001/pm8001_init.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/pm8001/pm8001_init.c
> b/drivers/scsi/pm8001/pm8001_init.c
> index 3861aa1..1ee61e8 100644
> --- a/drivers/scsi/pm8001/pm8001_init.c
> +++ b/drivers/scsi/pm8001/pm8001_init.c
> @@ -734,7 +734,7 @@ static u32 pm8001_request_irq(struct
> pm8001_hba_info *pm8001_ha)
> pdev = pm8001_ha->pdev;
>
> #ifdef PM8001_USE_MSIX
> - if (pci_find_capability(pdev, PCI_CAP_ID_MSIX))
> + if (pdev->msix_cap)
> return pm8001_setup_msix(pm8001_ha);
> else {
> PM8001_INIT_DBG(pm8001_ha,
> --
> 1.7.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 11/16] pm8001: clean up unnecessary MSI/MSI-X capability find
2013-08-09 2:57 ` lindar_liu
@ 2013-08-09 7:30 ` Yijing Wang
0 siblings, 0 replies; 3+ messages in thread
From: Yijing Wang @ 2013-08-09 7:30 UTC (permalink / raw)
To: lindar_liu
Cc: 'James E.J. Bottomley', 'Hanjun Guo', jiang.liu,
xjtuwjp, linux-scsi
On 2013/8/9 10:57, lindar_liu wrote:
> On 08/08/2013 9:10 PM, Yijing Wang wrote:
>> PCI core will initialize device MSI/MSI-X capability in
>> pci_msi_init_pci_dev(). So device driver should use pci_dev-
>>> msi_cap/msix_cap to determine whether the device support MSI/MSI-X
>> instead of using pci_find_capability(pci_dev, PCI_CAP_ID_MSI/MSIX).
>> Access to PCIe device config space again will consume more time.
>>
> It's fine.
> You can add my Acked-by.
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-09 7:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-08 13:10 [PATCH 11/16] pm8001: clean up unnecessary MSI/MSI-X capability find Yijing Wang
2013-08-09 2:57 ` lindar_liu
2013-08-09 7:30 ` Yijing Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox