public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: "Kiwoong Kim" <kwmad.kim@samsung.com>
To: "'Bao D. Nguyen'" <quic_nguyenb@quicinc.com>,
	<linux-scsi@vger.kernel.org>, <sc.suh@samsung.com>,
	<hy50.seo@samsung.com>, <sh425.lee@samsung.com>,
	<kwangwon.min@samsung.com>
Subject: RE: [RFC PATCH v1] ufs: poll HCS.UCRDY before issuing a UIC command
Date: Tue, 16 May 2023 12:28:15 +0900	[thread overview]
Message-ID: <012d01d987a6$733d2c10$59b78430$@samsung.com> (raw)
In-Reply-To: <991cac52-22bc-0150-4332-76ac044c5bcb@quicinc.com>

> > +	do {
> > +		val = ufshcd_readl(hba, REG_CONTROLLER_STATUS) &
> > +			UIC_COMMAND_READY;
> > +		if (val)
> > +			break;
> > +		usleep_range(500, 1000);
> Hi Kiwoong,
> It looks like you are sleeping while holding the spin_lock_irqsave(hba-
> >host->host_lock, flags) in ufshcd_send_uic_cmd()?

You're right. Let me fix it.



  parent reply	other threads:[~2023-05-16  3:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20230509083312epcas2p375f77d18a9026f7d263750baf9c9a5bb@epcas2p3.samsung.com>
2023-05-09  8:24 ` [RFC PATCH v1] ufs: poll HCS.UCRDY before issuing a UIC command Kiwoong Kim
2023-05-10 10:14   ` Avri Altman
2023-05-16  3:30     ` Kiwoong Kim
2023-05-10 18:53   ` Bart Van Assche
2023-05-10 21:24   ` Bao D. Nguyen
2023-05-10 21:46     ` Bart Van Assche
2023-05-10 23:35     ` Kiwoong Kim
2023-05-16  3:28     ` Kiwoong Kim [this message]
2023-05-11  5:22   ` Adrian Hunter
2023-05-12  0:56     ` Kiwoong Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='012d01d987a6$733d2c10$59b78430$@samsung.com' \
    --to=kwmad.kim@samsung.com \
    --cc=hy50.seo@samsung.com \
    --cc=kwangwon.min@samsung.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=quic_nguyenb@quicinc.com \
    --cc=sc.suh@samsung.com \
    --cc=sh425.lee@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox