Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: "Milan P. Gandhi" <mgandhi@redhat.com>
To: Bart Van Assche <bvanassche@acm.org>,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Cc: jejb@linux.ibm.com, martin.petersen@oracle.com,
	Laurence Oberman <loberman@redhat.com>
Subject: Re: [PATCH] scsi: core: Log SCSI command age with errors
Date: Thu, 26 Sep 2019 10:31:05 +0530	[thread overview]
Message-ID: <01be9696-b7ce-4601-0a0b-a7cbb234b1ce@redhat.com> (raw)
In-Reply-To: <c28778e6-62a1-b510-f6aa-fd67b54ca54c@acm.org>

On 9/25/19 9:15 PM, Bart Van Assche wrote:
> On 9/22/19 11:01 PM, Milan P. Gandhi wrote:
>> +    off += scnprintf(logbuf + off, logbuf_len - off,
>> +             "cmd-age=%lus", cmd_age);
> 
> Have you considered to change cmd-age into cmd_age? I'm afraid otherwise someone might interpret the hyphen as a subtraction sign...

Thanks for your suggestion Bart.
Yes, it would be better to use cmd_age to avoid any confusion.
I will change it and send the updated patch.

Thanks,
Milan.

  reply	other threads:[~2019-09-26  5:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-23  6:01 [PATCH] scsi: core: Log SCSI command age with errors Milan P. Gandhi
2019-09-23 13:02 ` Laurence Oberman
2019-09-23 13:24   ` Milan P. Gandhi
2019-09-25 15:45 ` Bart Van Assche
2019-09-26  5:01   ` Milan P. Gandhi [this message]
2019-09-27 15:26 ` Martin Wilck
2019-09-27 17:45   ` Laurence Oberman
2019-09-30  8:42     ` Martin Wilck
2019-09-30  9:05       ` Milan P. Gandhi
2019-09-30  9:46         ` Martin Wilck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01be9696-b7ce-4601-0a0b-a7cbb234b1ce@redhat.com \
    --to=mgandhi@redhat.com \
    --cc=bvanassche@acm.org \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=loberman@redhat.com \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox