From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com>,
mani@kernel.org, alim.akhtar@samsung.com, avri.altman@wdc.com,
bvanassche@acm.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, andersson@kernel.org,
konradybcio@kernel.org, agross@kernel.org
Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V1 1/3] dt-bindings: ufs: qcom: Add reg and reg-names
Date: Wed, 30 Jul 2025 14:44:30 +0200 [thread overview]
Message-ID: <01f2c5d5-6321-49af-b73c-6924f46d6646@kernel.org> (raw)
In-Reply-To: <bc07c850-c3ba-48bf-8ca2-a6ffda8440e8@kernel.org>
On 30/07/2025 13:33, Krzysztof Kozlowski wrote:
>>> "extending" but you are not extending at all.
>>>
>>> Recent qcom patches love to break ABI and impact users. No.
>>>
>>> Best regards,
>>> Krzysztof
>>
>>
>> Hi Krzysztof,
>>
>> Thanks for your feedback.
>>
>> Regarding your concern about this being an incompatible change — could you please clarify what specific aspect you believe breaks compatibility?
>> From my side, I’ve carefully tested the patch and verified that it does not break any existing DTs. I ran the following command to validate against the schema:
>
>
> I missed that earlier list is not actually used for SM8550 and SM8650.
> The syntax is a bit confusing after looking only at diff, which probably
> means this binding is getting messy.
>
> I think binding should be just split the constraints are easier to follow.
I sent a patch for splitting the bindings.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-30 12:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 8:22 [PATCH V1 0/3] Enable UFS MCQ support for SM8650 and SM8750 Ram Kumar Dwivedi
2025-07-30 8:22 ` [PATCH V1 1/3] dt-bindings: ufs: qcom: Add reg and reg-names Ram Kumar Dwivedi
2025-07-30 9:11 ` Krzysztof Kozlowski
2025-07-30 10:27 ` Ram Kumar Dwivedi
2025-07-30 11:33 ` Krzysztof Kozlowski
2025-07-30 12:44 ` Krzysztof Kozlowski [this message]
2025-07-30 8:22 ` [PATCH V1 2/3] arm64: dts: qcom: sm8650: Enable MCQ support for UFS controller Ram Kumar Dwivedi
2025-07-30 9:12 ` Krzysztof Kozlowski
2025-07-30 10:30 ` Ram Kumar Dwivedi
2025-07-31 6:45 ` Krzysztof Kozlowski
2025-07-31 8:34 ` Ram Kumar Dwivedi
2025-07-31 8:38 ` Krzysztof Kozlowski
2025-08-01 12:24 ` Manivannan Sadhasivam
2025-08-01 14:20 ` Krzysztof Kozlowski
2025-08-01 15:33 ` Manivannan Sadhasivam
2025-08-01 16:09 ` Krzysztof Kozlowski
2025-08-11 9:27 ` Manivannan Sadhasivam
2025-08-11 14:34 ` Ram Kumar Dwivedi
2025-08-12 11:51 ` Konrad Dybcio
2025-07-30 8:22 ` [PATCH V1 3/3] arm64: dts: qcom: sm8750: " Ram Kumar Dwivedi
2025-07-31 8:50 ` [PATCH V1 0/3] Enable UFS MCQ support for SM8650 and SM8750 neil.armstrong
2025-08-01 12:43 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01f2c5d5-6321-49af-b73c-6924f46d6646@kernel.org \
--to=krzk@kernel.org \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=quic_rdwivedi@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox