From: Tomas Henzl <thenzl@redhat.com>
To: Sasikumar Chandrasekaran <sasikumar.pc@broadcom.com>,
jejb@kernel.org, hch@infradead.org
Cc: linux-scsi@vger.kernel.org, Sathya.Prakash@broadcom.com,
linux-kernel@vger.kernel.org, christopher.owens@broadcom.com,
kiran-kumar.kasturi@broadcom.com
Subject: Re: [PATCH V6 00/11] megaraid_sas: Updates for scsi-next
Date: Fri, 23 Dec 2016 16:24:19 +0100 [thread overview]
Message-ID: <02164bad-0f41-92f3-1fdb-bffc75abbf85@redhat.com> (raw)
In-Reply-To: <1482455994-8047-1-git-send-email-sasikumar.pc@broadcom.com>
On 23.12.2016 02:19, Sasikumar Chandrasekaran wrote:
> Sasikumar Chandrasekaran (11):
> megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid
> Controllers
> megaraid_sas: 128 MSIX Support
> megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid
> Controllers
> megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and
> IO Coalescing
> megaraid_sas: SAS3.5 Generic Megaraid Controllers Fast Path for RAID
> 1/10 Writes
> megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid
> Controllers
> megaraid_sas: Add the Support for SAS3.5 Generic Megaraid Controllers
> Capabilities
> megaraid_sas: Enable or Disable Fast path based on the PCI Threshold
> Bandwidth
> megaraid_sas: ldio_outstanding variable is not decremented in
> completion path
> megaraid_sas: Implement the PD Map support for SAS3.5 Generic Megaraid
> Controllers
> megaraid_sas: driver version upgrade
>
> drivers/scsi/megaraid/megaraid_sas.h | 139 ++++--
> drivers/scsi/megaraid/megaraid_sas_base.c | 240 +++++++--
> drivers/scsi/megaraid/megaraid_sas_fp.c | 341 +++++++++++--
> drivers/scsi/megaraid/megaraid_sas_fusion.c | 750 +++++++++++++++++++++++-----
> drivers/scsi/megaraid/megaraid_sas_fusion.h | 364 ++++++++++++--
> 5 files changed, 1557 insertions(+), 277 deletions(-)
>
I finished review of this set and ack-ed it.
There still is a large amount (~1600) of checkpatch errors,
ERROR: DOS line endings
ERROR: trailing whitespace
...
I complained about this several times and was hoping that Sasi would fix all that in V6
but for some reason it hasn't been fixed.
I don't want to stop the series only because of formatting issues,
so well ok
-tm
next prev parent reply other threads:[~2016-12-23 15:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-23 1:19 [PATCH V6 00/11] megaraid_sas: Updates for scsi-next Sasikumar Chandrasekaran
2016-12-23 1:19 ` [PATCH V6 01/11] megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid Controllers Sasikumar Chandrasekaran
2016-12-23 1:19 ` [PATCH V6 02/11] megaraid_sas: 128 MSIX Support Sasikumar Chandrasekaran
2016-12-23 15:09 ` Tomas Henzl
2016-12-23 1:19 ` [PATCH V6 03/11] megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid Controllers Sasikumar Chandrasekaran
2016-12-23 1:19 ` [PATCH V6 04/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and IO Coalescing Sasikumar Chandrasekaran
2016-12-23 6:03 ` kbuild test robot
2016-12-23 1:19 ` [PATCH V6 05/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Fast Path for RAID 1/10 Writes Sasikumar Chandrasekaran
2016-12-23 1:19 ` [PATCH V6 06/11] megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers Sasikumar Chandrasekaran
2016-12-23 15:13 ` Tomas Henzl
2016-12-23 1:19 ` [PATCH V6 07/11] megaraid_sas: Add the Support for SAS3.5 Generic Megaraid Controllers Capabilities Sasikumar Chandrasekaran
2016-12-23 1:19 ` [PATCH V6 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth Sasikumar Chandrasekaran
2016-12-23 15:13 ` Tomas Henzl
2016-12-23 1:19 ` [PATCH V6 09/11] megaraid_sas: ldio_outstanding variable is not decremented in completion path Sasikumar Chandrasekaran
2016-12-23 1:19 ` [PATCH V6 10/11] megaraid_sas: Implement the PD Map support for SAS3.5 Generic Megaraid Controllers Sasikumar Chandrasekaran
2016-12-23 15:14 ` Tomas Henzl
2016-12-23 1:19 ` [PATCH V6 11/11] megaraid_sas: driver version upgrade Sasikumar Chandrasekaran
2016-12-23 15:24 ` Tomas Henzl [this message]
2016-12-23 16:32 ` [PATCH V6 00/11] megaraid_sas: Updates for scsi-next Tomas Henzl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02164bad-0f41-92f3-1fdb-bffc75abbf85@redhat.com \
--to=thenzl@redhat.com \
--cc=Sathya.Prakash@broadcom.com \
--cc=christopher.owens@broadcom.com \
--cc=hch@infradead.org \
--cc=jejb@kernel.org \
--cc=kiran-kumar.kasturi@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sasikumar.pc@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).