From: "Tony Battersby" <tonyb@cybernetics.com>
To: 'James Bottomley' <James.Bottomley@steeleye.com>,
"'Justin T. Gibbs'" <gibbs@scsiguy.com>
Cc: linux-scsi@vger.kernel.org
Subject: RE: [PATCH] sd.c fixes applied incorectly to 2.4.19-preXX
Date: Tue, 16 Apr 2002 11:25:06 -0400 [thread overview]
Message-ID: <02Apr16.112509edt.119051@cyborg.cybernetics.com> (raw)
In-Reply-To: <200204161456.g3GEuo302374@localhost.localdomain>
> > If you insist on doing this, lets at least preserve the current
> > behavior:
>
> > /*
> > * FIXME: this driver treats deferred errors are fatal for
> [...]
> > if (scsi_sense_valid(SCpnt)
> > && scsi_sense_key(SCpnt) == SKEY_CURRENT_ERROR) {
>
> Excellent! It's a lot more readable for people not versed in
> sense buffer
> layout, thanks!
Why are you calling it the sense key? Current vs. deferred error is
indicated by the error code (sense_data[0] & 0x7f), not the sense key
(sense_data[2] & 0x0f). Calling it the sense key may lead to confusion for
those who are versed in sense buffer layout.
Tony
next prev parent reply other threads:[~2002-04-16 15:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-15 20:40 [PATCH] sd.c fixes applied incorectly to 2.4.19-preXX Justin T. Gibbs
2002-04-15 20:51 ` James Bottomley
2002-04-15 21:13 ` Justin T. Gibbs
2002-04-16 14:03 ` James Bottomley
2002-04-16 14:43 ` Justin T. Gibbs
2002-04-16 14:56 ` James Bottomley
2002-04-16 15:25 ` Tony Battersby [this message]
2002-04-16 17:36 ` Justin T. Gibbs
2002-04-16 16:18 ` Oliver Xymoron
2002-04-16 17:38 ` Justin T. Gibbs
2002-04-16 5:58 ` Jens Axboe
2002-04-16 14:08 ` Justin T. Gibbs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02Apr16.112509edt.119051@cyborg.cybernetics.com \
--to=tonyb@cybernetics.com \
--cc=James.Bottomley@steeleye.com \
--cc=gibbs@scsiguy.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox