From mboxrd@z Thu Jan 1 00:00:00 1970 From: "NickCheng" Subject: RE: [Fwd: [patch] [SCSI] arcmsr: fix misuse of | instead of &] Date: Wed, 20 Jun 2012 09:38:10 +0800 Message-ID: <02F0C1478CF5442C9D543E3A87B82B82@arecaaebe11fae> References: <1340121415.3004.57.camel@dabdike.int.hansenpartnership.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-gg0-f174.google.com ([209.85.161.174]:46897 "EHLO mail-gg0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752044Ab2FTBlB (ORCPT ); Tue, 19 Jun 2012 21:41:01 -0400 Received: by gglu4 with SMTP id u4so5262093ggl.19 for ; Tue, 19 Jun 2012 18:41:00 -0700 (PDT) In-Reply-To: <1340121415.3004.57.camel@dabdike.int.hansenpartnership.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: 'James Bottomley' Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Hi James, Sorry for be late response. I am OK with it. -----Original Message----- From: James Bottomley [mailto:James.Bottomley@HansenPartnership.com] Sent: Tuesday, June 19, 2012 11:57 PM To: Nick Cheng Subject: [Fwd: [patch] [SCSI] arcmsr: fix misuse of | instead of &] Is this OK with you? James -------- Forwarded Message -------- From: Dan Carpenter To: James E.J. Bottomley Cc: David Howells , Nick Cheng , , kernel-janitors@vger.kernel.org Subject: [patch] [SCSI] arcmsr: fix misuse of | instead of & Date: Sat, 9 Jun 2012 12:10:19 +0300 ARCMSR_ARC1880_DiagWrite_ENABLE is 0x00000080 so (x | 0x00000080) is never zero. The intent here was to test that loop until ARCMSR_ARC1880_DiagWrite_ENABLE was turned on, but because the test was wrong, we would do five loops regardless of whether it succeed or not. Also I simplified the condition a little by removing the unused assignement. Signed-off-by: Dan Carpenter --- Static checker stuff. I do not own this hardware. diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index cbde1dc..def24a1 100644 --- a/drivers/scsi/arcmsr/arcmsr_hba.c +++ b/drivers/scsi/arcmsr/arcmsr_hba.c @@ -2821,7 +2821,7 @@ static void arcmsr_hardware_reset(struct AdapterControlBlock *acb) int i, count = 0; struct MessageUnit_A __iomem *pmuA = acb->pmuA; struct MessageUnit_C __iomem *pmuC = acb->pmuC; - u32 temp = 0; + /* backup pci config data */ printk(KERN_NOTICE "arcmsr%d: executing hw bus reset .....\n", acb->host->host_no); for (i = 0; i < 64; i++) { @@ -2839,7 +2839,7 @@ static void arcmsr_hardware_reset(struct AdapterControlBlock *acb) writel(0x2, &pmuC->write_sequence); writel(0x7, &pmuC->write_sequence); writel(0xD, &pmuC->write_sequence); - } while ((((temp = readl(&pmuC->host_diagnostic)) | ARCMSR_ARC1880_DiagWrite_ENABLE) == 0) && (count < 5)); + } while (((readl(&pmuC->host_diagnostic) & ARCMSR_ARC1880_DiagWrite_ENABLE) == 0) && (count < 5)); writel(ARCMSR_ARC1880_RESET_ADAPTER, &pmuC->host_diagnostic); } else { pci_write_config_byte(acb->pdev, 0x84, 0x20); -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html