Re: [PATCH 1/2] scsi: ufs: Add an enum for ufs_trace to check ufs cmd error

Bart Van Assche
2025-09-08T15:28:13Z

On 9/8/25 12:43 AM, DooHyun Hwang wrote:
> Would it be acceptable to add UFS_UIC_SEND, UFS_UIC_COMP,
> and UFS_UIC_ERR at the end of the enum?
>
> I am aware that UFS_DEV_COMP is currently not used in the code,
> but I am concerned about whether it is appropriate to modify
> or remove existing enum labels.

Please take a look at Documentation/process/stable-api-nonsense.rst.
While the Android GKI kernels have a stable ABI, the upstream kernel
does not promise a stable ABI. Hence, the concerns that apply to GKI
kernels regarding changing the numerical value of enum labels do not
apply to the upstream kernel. It is the responsibility of anyone who
backports an upstream patch to a GKI kernel branch to make sure that
the GKI ABI is not modified.

Thanks,

Bart.