RE: [PATCH 1/2] scsi: ufs: Add an enum for ufs_trace to check ufs cmd error

DooHyun Hwang
2025-09-03T06:39:26Z

On 9/2/25 9:35 AM, Bart Van Assche wrote:
> On 9/1/25 6:09 PM, DooHyun Hwang wrote:
> > The UFS_CMD_ERR stands for "command completion error."
>
> I've never before seen anyone abbreviating "completion" as "CMD".
> Please choose a better enumeration label name.
>
> Bart.

When I reviewed the UFS_CMD_TRACE_STRINGS definition,
I noticed that "query_complete_err" is referred to as UFS_QUERY_ERR,
and "tm_complete_err" is referred to as UFS_TM_ERR.

I followed the naming convention specified in this STRINGS definition,
but I’m not entirely clear on what changes are being requested.

Could you please provide some guidance or suggestions?

Thank you.
DooHyun Hwang.