RE: [PATCH 2/2] scsi: ufs: core: Add a trace function calling when uic command error occurs

DooHyun Hwang
2025-04-18T04:48:57Z

> On 4/16/25 7:34 PM, DooHyun Hwang wrote:
> > When a uic command error occurs, there is no trace function calling.
> > Therefore, trace function calls are added when a uic command error
> happens.
> >
> > Signed-off-by: DooHyun Hwang <dh0421.hwang@samsung.com>
> > ---
> > drivers/ufs/core/ufshcd.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> > index ab98acd982b5..baac1ae94efc 100644
> > --- a/drivers/ufs/core/ufshcd.c
> > +++ b/drivers/ufs/core/ufshcd.c
> > @@ -2534,6 +2534,9 @@ ufshcd_wait_for_uic_cmd(struct ufs_hba *hba,
> struct uic_command *uic_cmd)
> > hba->active_uic_cmd = NULL;
> > spin_unlock_irqrestore(hba->host->host_lock, flags);
> >
> > + if (ret)
> > + ufshcd_add_uic_command_trace(hba, uic_cmd, UFS_CMD_ERR);
> > +
> > return ret;
> > }
> >
> > @@ -4306,6 +4309,8 @@ static int ufshcd_uic_pwr_ctrl(struct ufs_hba *hba,
> struct uic_command *cmd)
> > }
> > out:
> > if (ret) {
> > + ufshcd_add_uic_command_trace(hba, hba->active_uic_cmd,
> > + UFS_CMD_ERR);
> > ufshcd_print_host_state(hba);
> > ufshcd_print_pwr_info(hba);
> > ufshcd_print_evt_hist(hba);
>
> Shouldn't the value of 'ret' be included in the UFS_CMD_ERR trace output?
>
> Thanks,
>
> Bart.
Thank you for your insightful feedback.

Upon further consideration, it seems that the existing trace, which captures detailed information through the UICCMDARG1 to UICCMDARG3 fields.
That already provides sufficient context for analyzing command-related issues.
The UFS_CMD_ERR trace output, combined with UICCMDARG* values, should be adequate for diagnosing errors and understanding the command's execution status.

BR,
Thank you.
DooHyun Hwang.