From: "Peter Wang (王信友)" <peter.wang@mediatek.com>
To: "bvanassche@acm.org" <bvanassche@acm.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "avri.altman@wdc.com" <avri.altman@wdc.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
Sanjeev Y <Sanjeev.Y@mediatek.com>,
"santoshsy@gmail.com" <santoshsy@gmail.com>,
"quic_nguyenb@quicinc.com" <quic_nguyenb@quicinc.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
"manivannan.sadhasivam@linaro.org"
<manivannan.sadhasivam@linaro.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"James.Bottomley@HansenPartnership.com"
<James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH] scsi: core: ufs: Fix a hang in the error handler
Date: Thu, 29 May 2025 09:43:19 +0000 [thread overview]
Message-ID: <03ccea47401a5754fffaae91c549857478545a36.camel@mediatek.com> (raw)
In-Reply-To: <6d82c9dd-b93d-4400-9500-a850b1ba0bb7@acm.org>
On Wed, 2025-05-28 at 08:43 -0700, Bart Van Assche wrote:
> Hi Peter,
>
> It seems to me that this patch doesn't have any adverse side effects
> and
> also that it fixes a bug, namely that ufshcd_set_eh_in_progress()
> should
> be called after ufshcd_err_handling_prepare() instead of before. Do
> you
> agree with this and do you also agree that it would be good to have
> this
> patch upstream?
>
> Thank you,
>
> Bart.
Hi Bart,
Yes, this patch should be able to solve part of the problem
and shouldn't cause any side effects.
Reviewed-by: Peter Wang <peter.wang@mediatek.com>
next prev parent reply other threads:[~2025-05-29 9:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 20:14 [PATCH] scsi: core: ufs: Fix a hang in the error handler Bart Van Assche
2025-05-26 13:21 ` Peter Wang (王信友)
2025-05-27 22:01 ` Bart Van Assche
2025-05-28 8:32 ` Peter Wang (王信友)
2025-05-28 15:43 ` Bart Van Assche
2025-05-29 9:43 ` Peter Wang (王信友) [this message]
2025-06-04 2:00 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03ccea47401a5754fffaae91c549857478545a36.camel@mediatek.com \
--to=peter.wang@mediatek.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=Sanjeev.Y@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=quic_nguyenb@quicinc.com \
--cc=santoshsy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox