Re: [PATCH 3/3] dt-bindings: ufs: qcom: Document HS gear and rate limit properties

Dmitry Baryshkov
2025-07-22T19:02:38Z

On Tue, Jul 22, 2025 at 09:41:03PM +0530, Ram Kumar Dwivedi wrote:
> Add documentation for two new optional properties:
> - limit-hs-gear
> - limit-rate
>
> These properties allow platforms to restrict the maximum high-speed
> gear and rate used by the UFS controller. This is required for
> certain automotive platforms with hardware constraints.

Please reformat other way around: describe the actual problem (which
platforms, which constraints, what breaks, etc). Then describe your
solution.

>
> Signed-off-by: Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com>
> ---
> Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> index 6c6043d9809e..9dedd09df9e0 100644
> --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> @@ -111,6 +111,16 @@ properties:
> description:
> GPIO connected to the RESET pin of the UFS memory device.
>
> + limit-hs-gear:

If the properties are generic, they should go to the ufs-common.yaml. If
not (but why?), then they should be prefixed with 'qcom,' prefix, as
usual.

> + maxItems: 1
> + description:
> + Limit max phy hs gear
> +
> + limit-rate:
> + maxItems: 1
> + description:
> + Limit max phy hs rate
> +
> required:
> - compatible
> - reg
> --
> 2.50.1
>

--
With best wishes
Dmitry