public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: "Hironobu Ishii" <ishii.hironobu@jp.fujitsu.com>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>
Subject: [PATCH] message fix of scsi_mod.
Date: Wed, 31 Mar 2004 21:31:36 +0900	[thread overview]
Message-ID: <040a01c4171c$4ead2630$2987110a@lsd.css.fujitsu.com> (raw)

Hi James,

This patch:
    - fixes a message it does not tell us the error device.
    - fixes weird messages from scsi_sysfs.c

This is a patch for linux-2.6.5-rc3.

Please apply!

Thanks,
Hironobu Ishii.

diff -urN linux-2.6.5-rc3/drivers/scsi/scsi_scan.c linux-2.6.5-rc3-work/drivers/scsi/scsi_scan.c
--- linux-2.6.5-rc3/drivers/scsi/scsi_scan.c 2004-03-30 19:02:47.000000000 +0900
+++ linux-2.6.5-rc3-work/drivers/scsi/scsi_scan.c 2004-03-31 19:12:37.195529071 +0900
@@ -403,10 +403,12 @@
    /* if the longer inquiry has failed, flag the device
     * as only accepting 36 byte inquiries and retry the
     * 36 byte inquiry */
-   printk(KERN_INFO "scsi scan: %d byte inquiry failed"
-          " with code %d.  Consider BLIST_INQUIRY_36 for"
-          " this device\n", possible_inq_resp_len,
-          sreq->sr_result);
+   printk(KERN_INFO "scsi scan: <%d:%d:%d:%d>: "
+          "%d byte inquiry failed with code %d.  "
+          "Consider BLIST_INQUIRY_36 for this device\n",
+          sdev->host->host_no, sdev->channel,
+          sdev->id, sdev->lun,
+          possible_inq_resp_len, sreq->sr_result);
    *bflags = BLIST_INQUIRY_36;
    goto repeat_inquiry;
   }
diff -urN linux-2.6.5-rc3/drivers/scsi/scsi_sysfs.c linux-2.6.5-rc3-work/drivers/scsi/scsi_sysfs.c
--- linux-2.6.5-rc3/drivers/scsi/scsi_sysfs.c 2004-03-30 19:02:47.000000000 +0900
+++ linux-2.6.5-rc3-work/drivers/scsi/scsi_sysfs.c 2004-03-31 19:20:15.990455170 +0900
@@ -358,13 +358,15 @@
 
  error = device_add(&sdev->sdev_gendev);
  if (error) {
-  printk(KERN_INFO "error 1\n");
+  printk(KERN_INFO "scsi_sysfs: device_add() failed on <%d:%d:%d:%d>\n",
+   sdev->host->host_no, sdev->channel, sdev->id, sdev->lun );
   return error;
  }
 
  error = class_device_add(&sdev->sdev_classdev);
  if (error) {
-  printk(KERN_INFO "error 2\n");
+  printk(KERN_INFO "scsi_sysfs: class_device_add failed on <%d:%d:%d:%d>\n",
+   sdev->host->host_no, sdev->channel, sdev->id, sdev->lun);
   goto clean_device;
  }
  /* take a reference for the sdev_classdev; this is


                 reply	other threads:[~2004-03-31 12:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='040a01c4171c$4ead2630$2987110a@lsd.css.fujitsu.com' \
    --to=ishii.hironobu@jp.fujitsu.com \
    --cc=James.Bottomley@SteelEye.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox